[PATCH 0/3] Fix how for-each-ref handles broken loose references

Currently, "git for-each-ref" fails to handle REF_ISBROKEN references correctly, treating them instead as valid references that point at NULL_SHA1. Sometimes this makes for-each-ref emit the wrong error message; sometimes it even appears to complete successfully.

Instead, emit warnings for broken references but otherwise ignore them. Also, add special-case code to defend against an actual NULL_SHA1 in a loose reference file being treated as valid. (We've seen that problem on our servers before, probably caused by the Ruby Git client that we used to use.)

This patch series was prepared against "maint" as it might be suitable for that branch, but it also applies cleanly against "master".

This patch series is also available from my GitHub account [1], as branch for-each-ref-errors.

[1] https://github.com/mhagger/git

Michael Haggerty (3):
  t6301: new tests of for-each-ref error handling
  for-each-ref: report broken references correctly
  read_loose_refs(): treat NULL_SHA1 loose references as broken

 builtin/for-each-ref.c         |  5 +++++
 refs.c                         |  7 +++++++
 t/t6301-for-each-ref-errors.sh | 45 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 57 insertions(+)
 create mode 100755 t/t6301-for-each-ref-errors.sh