[PATCH 0/2] don't add duplicate paths to info/alternates
- From
Jim Hill <gjthill@gmail.com>
- Date
- May 31, 2015, 18:15 UTC
- Message-ID
- <1433096123-14420-1-git-send-email-gjthill@gmail.com>
These patches address http://thread.gmane.org/gmane.comp.version-control.git/269050/focus=269415 linked from the git blame page, avoiding adding duplicates to info/alternates and removing hold_lock_file_for_append which is too heavyweight for logging and too limited for anything else.
There's an argument to be made that since a-t-a-f is only used by clone, it shouldn't even bother taking a lock -- but then it should be moved to builtin/clone.c and reduced to a single write of the pre-deduped list, followed by a single read_info_alternates call. One thing at a time. Taking out the locking in the incremental version here doesn't really simplify the code much anyway.