git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/clean.c: Handle disappearing files

From
David Turner <dturner@twopensource.com>
Date
May 15, 2015, 18:13 UTC
Message-ID
<1431713612.17436.27.camel@ubuntu>
In-Reply-To
<xmqqy4kqh0n8.fsf@gitster.dls.corp.google.com>

On Thu, 2015-05-14 at 22:26 -0700, Junio C Hamano wrote: <snip>

OK, I'm sold that this patch is not a great idea. But:
Show 6 quoted lines
> If your "build statistics" thing
> created a temporary before "clean" started to run (causing 'clean'
> to notice that as a cruft), and if "clean" gets to remove it before
> the "build statistics" thing finishes what it was doing accumulating
> whatever data in that file, when "build statistics" thing finally
> tries to use the file, it no longer is there.

Only if the build statistics file is included in the pathspec for clean.

So maybe we should just move the lstat below the pathspec check. This is probably faster in some cases anyway. What do you think?

Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 8 in “builtin/clean.c: Handle disappearing files”
  1. builtin/clean.c: Handle disappearing filesDavid Turner, May 14, 2015
  2. Junio C HamanoMay 14, 2015
  3. David TurnerMay 14, 2015
  4. Junio C HamanoMay 14, 2015
  5. David TurnerMay 14, 2015
  6. Junio C HamanoMay 15, 2015
  7. David TurnerMay 15, 2015
  8. Junio C HamanoMay 16, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.