git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/6] merge: tidy up options

From
SRStephen Robin <stephen.robin@gmail.com>
Date
May 6, 2015, 00:00 UTC
Message-ID
<1430870453-5408-2-git-send-email-stephen.robin@gmail.com>
In-Reply-To
<1430870453-5408-1-git-send-email-stephen.robin@gmail.com>

THIS PATCH SERIES IS NOT CODE-COMPLETE OR FULLY TESTED. See code comments beginning TODO for work remaining.

Hide --summary (it is a deprecated synonym for --stat). Correct capitalization of the description of --verify-signatures. Correct indentation of code.

Signed-off-by: Stephen Robin <stephen.robin@gmail.com>
---
 builtin/merge.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/builtin/merge.c b/builtin/merge.c
index 3b0f8f9..d6b0579 100644
--- a/builtin/merge.c
+++ b/builtin/merge.c
@@ -194,10 +194,10 @@ static struct option builtin_merge_options[] = {
 		PARSE_OPT_NOARG, option_parse_n },
 	OPT_BOOL(0, "stat", &show_diffstat,
 		N_("show a diffstat at the end of the merge")),
-	OPT_BOOL(0, "summary", &show_diffstat, N_("(synonym to --stat)")),
+	OPT_HIDDEN_BOOL(0, "summary", &show_diffstat, N_("(synonym to --stat)")),
 	{ OPTION_INTEGER, 0, "log", &shortlog_len, N_("n"),
-	  N_("add (at most <n>) entries from shortlog to merge commit message"),
-	  PARSE_OPT_OPTARG, NULL, DEFAULT_MERGE_LOG_LEN },
+		N_("add (at most <n>) entries from shortlog to merge commit message"),
+		PARSE_OPT_OPTARG, NULL, DEFAULT_MERGE_LOG_LEN },
 	OPT_BOOL(0, "squash", &squash,
 		N_("create a single commit instead of doing a merge")),
 	OPT_BOOL(0, "commit", &option_commit,
@@ -210,7 +210,7 @@ static struct option builtin_merge_options[] = {
 		PARSE_OPT_NOARG | PARSE_OPT_NONEG, NULL, FF_ONLY },
 	OPT_RERERE_AUTOUPDATE(&allow_rerere_auto),
 	OPT_BOOL(0, "verify-signatures", &verify_signatures,
-		N_("Verify that the named commit has a valid GPG signature")),
+		N_("verify that the named commit has a valid GPG signature")),
 	OPT_CALLBACK('s', "strategy", &use_strategies, N_("strategy"),
 		N_("merge strategy to use"), option_parse_strategy),
 	OPT_CALLBACK('X', "strategy-option", &xopts, N_("option=value"),
@@ -223,7 +223,7 @@ static struct option builtin_merge_options[] = {
 		N_("abort the current in-progress merge")),
 	OPT_SET_INT(0, "progress", &show_progress, N_("force progress reporting"), 1),
 	{ OPTION_STRING, 'S', "gpg-sign", &sign_commit, N_("key-id"),
-	  N_("GPG sign commit"), PARSE_OPT_OPTARG, NULL, (intptr_t) "" },
+		N_("GPG sign commit"), PARSE_OPT_OPTARG, NULL, (intptr_t) "" },
 	OPT_BOOL(0, "overwrite-ignore", &overwrite_ignore, N_("update ignored files (default)")),
 	OPT_END()
 };
-- 
2.4.0.7.gf20f26f
Previous: Stephen RobinNext: Stephen Robin
Message 5 of 13 in “GSoC 2015: 2 accepted proposals”
  1. Matthieu MoyApr 27, 2015
  2. Paul TanApr 28, 2015
  3. Johannes SchindelinApr 29, 2015
  4. 0/6 Make pull a builtinStephen Robin, May 6, 2015
  5. 1/6 merge: tidy up optionsStephen Robin, May 6, 2015
  6. 2/6 merge: move error message given when a merge needs committing to advice.cStephen Robin, May 6, 2015
  7. 3/6 merge-base: split handle_fork_point to make reuse easierStephen Robin, May 6, 2015
  8. 4/6 pull: reimplement as a builtin in CStephen Robin, May 6, 2015
  9. 5/6 pull: allow interactive rebaseStephen Robin, May 6, 2015
  10. Johannes SchindelinMay 6, 2015
  11. 6/6 parse-remote: dismantle git-parse-remote.shStephen Robin, May 6, 2015
  12. Paul TanMay 6, 2015
  13. karthik nayakApr 28, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.