git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fixup test-lint error in git-p4 t9814 test

From
Luke Diamand <luke@diamand.org>
Date
Apr 27, 2015, 22:20 UTC
Message-ID
<1430173228-22004-1-git-send-email-luke@diamand.org>

While running the git-p4 tests, I noticed that t9814 has started failing due to the (very ingenious!) chain-lint detection introduced in:

   bb79af9 t/test-lib: introduce --chain-lint option

I think that what's going on is that the chain-lint test is getting itself confused by this test, which is designed to always succeed, regardless of whether the individual sub-commands succeed or not, since it's just setting up a pre-requisite for later use.

I've added an additional set of braces, which makes it clearer to the --chain-lint code what's going on, but I'd be interested to know if this is the right way to fix this.

Thanks, Luke

Luke Diamand (1):
  git-p4: prevent --chain-lint failure
 t/t9814-git-p4-rename.sh | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
-- 
2.3.4.48.g223ab37
Next: Luke Diamand
Message 1 of 3 in “Fixup test-lint error in git-p4 t9814 test”
  1. Fixup test-lint error in git-p4 t9814 testLuke Diamand, Apr 27, 2015
  2. git-p4: prevent --chain-lint failureLuke Diamand, Apr 27, 2015
  3. Jeff KingApr 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.