git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/6] wt-status.c: fix a memleak

From
Stefan Beller <sbeller@google.com>
Date
Mar 27, 2015, 22:09 UTC
Message-ID
<1427494150-8085-8-git-send-email-sbeller@google.com>
In-Reply-To
<1427494150-8085-1-git-send-email-sbeller@google.com>

In any code path of shorten_unambiguous_ref the return value is a xstrdup(some string), so it is safe to free the variable `base` in any codepath.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 wt-status.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/wt-status.c b/wt-status.c
index 853419f..9d2a349 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -1576,6 +1576,8 @@ static void wt_shortstatus_print_tracking(struct wt_status *s)
 
 	color_fprintf(s->fp, header_color, "]");
 	fputc(s->null_termination ? '\0' : '\n', s->fp);
+
+	free((char *)base);
 }
 
 void wt_shortstatus_print(struct wt_status *s)
-- 
2.3.0.81.gc37f363
Previous: Stefan BellerNext: Stefan Beller
Message 8 of 12 in “Memory leaks once again”
  1. 0/6 Memory leaks once againStefan Beller, Mar 27, 2015
  2. 1/6 pack-bitmap: fix a memleakStefan Beller, Mar 27, 2015
  3. 1/6 shallow: fix a memleakStefan Beller, Mar 27, 2015
  4. 2/6 line-log.c: fix a memleakStefan Beller, Mar 27, 2015
  5. 2/6 shallow: fix a memleakStefan Beller, Mar 27, 2015
  6. 3/6 line-log.c: fix a memleakStefan Beller, Mar 27, 2015
  7. 4/6 line-log.c: fix a memleakStefan Beller, Mar 27, 2015
  8. 4/6 wt-status.c: fix a memleakStefan Beller, Mar 27, 2015
  9. 5/6 pack-bitmap: fix a memleakStefan Beller, Mar 27, 2015
  10. 5/6 wt-status.c: fix a memleakStefan Beller, Mar 27, 2015
  11. 6/6 WIP/RFC/entry.c: fix a memleakStefan Beller, Mar 27, 2015
  12. Stefan BellerMar 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.