git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] send-email: Add CCs from additional commit tags

From
SBSoren Brinkmann <soren.brinkmann@xilinx.com>
Date
Mar 6, 2015, 21:59 UTC
Message-ID
<1425679161-13963-1-git-send-email-soren.brinkmann@xilinx.com>
Add email addresses from additional commonly used tags to the CC-list of
patches. Additional tags are:
 - Acked-by
 - Reviewed-by
 - Tested-by
 - Reported-by
 - Reviewed-and-tested-by
--suppress-cc=ack suppresses these additional CCs.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
 Documentation/git-send-email.txt | 3 +++
 git-send-email.perl              | 5 +++--
 2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index f248a8665e1f..1b521446ca11 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
@@ -293,6 +293,9 @@ Automating
   patch body (commit message) except for self (use 'self' for that).
 - 'sob' will avoid including anyone mentioned in Signed-off-by lines except
    for self (use 'self' for that).
+- 'ack' will avoid including anyone who acked the  patch (mentioned in
+  Acked-by, Reviewed-by, Tested-by, Reviewed-and-tested-by lines except for
+  self (use 'self' for that).
 - 'cccmd' will avoid running the --cc-cmd.
 - 'body' is equivalent to 'sob' + 'bodycc'
 - 'all' will suppress all auto cc values.
diff --git a/git-send-email.perl b/git-send-email.perl
index 3092ab356c76..18eb8a5139a4 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -407,7 +407,7 @@ my(%suppress_cc);
 if (@suppress_cc) {
 	foreach my $entry (@suppress_cc) {
 		die "Unknown --suppress-cc field: '$entry'\n"
-			unless $entry =~ /^(?:all|cccmd|cc|author|self|sob|body|bodycc)$/;
+			unless $entry =~ /^(?:all|cccmd|cc|author|self|sob|body|bodycc|ack)$/;
 		$suppress_cc{$entry} = 1;
 	}
 }
@@ -1452,7 +1452,7 @@ foreach my $t (@files) {
 	# Now parse the message body
 	while(<$fh>) {
 		$message .=  $_;
-		if (/^(Signed-off-by|Cc): (.*)$/i) {
+		if (/^(Signed-off-by|Cc|Acked-by|Reviewed-by|Tested-by|Reported-by|Reviewed-and-tested-by): (.*)$/i) {
 			chomp;
 			my ($what, $c) = ($1, $2);
 			chomp $c;
@@ -1462,6 +1462,7 @@ foreach my $t (@files) {
 			} else {
 				next if $suppress_cc{'sob'} and $what =~ /Signed-off-by/i;
 				next if $suppress_cc{'bodycc'} and $what =~ /Cc/i;
+				next if $suppress_cc{'ack'} and $what =~ /(Acked-by|Reviewed-by|Tested-by|Reported-by|Reviewed-and-tested-by)/i;
 			}
 			push @cc, $c;
 			printf("(body) Adding cc: %s from line '%s'\n",
-- 
2.3.1.2.g90df61e.dirty
Next: Eric Sunshine
Message 1 of 2 in “send-email: Add CCs from additional commit tags”
  1. send-email: Add CCs from additional commit tagsSoren Brinkmann, Mar 6, 2015
  2. Eric SunshineMar 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.