git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] Makes chooser set 'gitdir' to the resolved path

From
Remi Rampin <remirampin@gmail.com>
Date
Mar 6, 2015, 16:21 UTC
Message-ID
<1425658913-2721-3-git-send-email-remirampin@gmail.com>
In-Reply-To
<1425658913-2721-1-git-send-email-remirampin@gmail.com>

If _is_git follows a "gitdir: ..." file link to get to the actual repository, we want _gitdir to be set to that final path.

Signed-off-by: Remi Rampin <remirampin@gmail.com>
---
 lib/choose_repository.tcl | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/lib/choose_repository.tcl b/lib/choose_repository.tcl
index abc6b1d..75d1da8 100644
--- a/lib/choose_repository.tcl
+++ b/lib/choose_repository.tcl
@@ -338,7 +338,10 @@ method _git_init {} {
 	return 1
 }
 
-proc _is_git {path} {
+proc _is_git {path {outdir_var ""}} {
+	if {$outdir_var ne ""} {
+		upvar 1 $outdir_var outdir
+	}
 	if {[file isfile $path]} {
 		set fp [open $path r]
 		gets $fp line
@@ -352,12 +355,14 @@ proc _is_git {path} {
 	if {[file exists [file join $path HEAD]]
 	 && [file exists [file join $path objects]]
 	 && [file exists [file join $path config]]} {
+		set outdir $path
 		return 1
 	}
 	if {[is_Cygwin]} {
 		if {[file exists [file join $path HEAD]]
 		 && [file exists [file join $path objects.lnk]]
 		 && [file exists [file join $path config.lnk]]} {
+			set outdir $path
 			return 1
 		}
 	}
@@ -1103,7 +1108,7 @@ method _open_local_path {} {
 }
 
 method _do_open2 {} {
-	if {![_is_git [file join $local_path .git]]} {
+	if {![_is_git [file join $local_path .git] actualgit]} {
 		error_popup [mc "Not a Git repository: %s" [file tail $local_path]]
 		return
 	}
@@ -1116,7 +1121,7 @@ method _do_open2 {} {
 	}
 
 	_append_recentrepos [pwd]
-	set ::_gitdir .git
+	set ::_gitdir $actualgit
 	set ::_prefix {}
 	set done 1
 }
-- 
1.9.5.msysgit.0
Previous: Remi RampinNext: Pat Thoyts
Message 3 of 4 in “[git-gui] "Open existing repository" with submodules”
  1. 0/2 [git-gui] "Open existing repository" with submodulesRemi Rampin, Mar 6, 2015
  2. 1/2 Fixes chooser not accepting gitfilesRemi Rampin, Mar 6, 2015
  3. 2/2 Makes chooser set 'gitdir' to the resolved pathRemi Rampin, Mar 6, 2015
  4. Pat ThoytsMar 12, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.