[PATCH v2 1/7] write_ref_sha1(): remove check for lock == NULL

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Mar 2, 2015, 09:29 UTC
Message-ID: <1425288597-20547-2-git-send-email-mhagger@alum.mit.edu>
In-Reply-To: <1425288597-20547-1-git-send-email-mhagger@alum.mit.edu>

None of the callers pass NULL to this function, and there doesn't seem to be any usefulness to allowing them to do so.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Reviewed-by: Stefan Beller <sbeller@google.com>
---
 refs.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/refs.c b/refs.c
index ab2f2a9..e82d503 100644
--- a/refs.c
+++ b/refs.c
@@ -3079,10 +3079,6 @@ static int write_ref_sha1(struct ref_lock *lock,
 	static char term = '\n';
 	struct object *o;
 
-	if (!lock) {
-		errno = EINVAL;
-		return -1;
-	}
 	if (!lock->force_write && !hashcmp(lock->old_sha1, sha1)) {
 		unlock_ref(lock);
 		return 0;

-- 
2.1.4