git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] hex.c: reduce memory footprint of sha1_to_hex static buffers

From
Stefan Beller <sbeller@google.com>
Date
Feb 13, 2015, 21:18 UTC
Message-ID
<1423862329-7899-1-git-send-email-sbeller@google.com>

41 bytes is the exact number of bytes needed for having the returned hex string represented. 50 seems to be an arbitrary number, such that there are no benefits from alignment to certain address boundaries.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 hex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hex.c b/hex.c
index 9ebc050..cfd9d72 100644
--- a/hex.c
+++ b/hex.c
@@ -59,7 +59,7 @@ int get_sha1_hex(const char *hex, unsigned char *sha1)
 char *sha1_to_hex(const unsigned char *sha1)
 {
 	static int bufno;
-	static char hexbuffer[4][50];
+	static char hexbuffer[4][41];
 	static const char hex[] = "0123456789abcdef";
 	char *buffer = hexbuffer[3 & ++bufno], *buf = buffer;
 	int i;
-- 
2.3.0.81.gc37f363
Next: Junio C Hamano
Message 1 of 5 in “hex.c: reduce memory footprint of sha1_to_hex static buffers”
  1. hex.c: reduce memory footprint of sha1_to_hex static buffersStefan Beller, Feb 13, 2015
  2. Junio C HamanoFeb 13, 2015
  3. Stefan BellerFeb 13, 2015
  4. Linus TorvaldsFeb 13, 2015
  5. Junio C HamanoFeb 13, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.