git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 2/2] format-patch: ignore diff.submodule setting

From
Doug Kelly <dougk.ff7@gmail.com>
Date
Jan 7, 2015, 20:13 UTC
Message-ID
<1420661623-30692-2-git-send-email-dougk.ff7@gmail.com>
In-Reply-To
<1420661623-30692-1-git-send-email-dougk.ff7@gmail.com>

diff.submodule when set to log produces output which git-am cannot handle. Ignore this setting when generating patch output.

Signed-off-by: Doug Kelly <dougk.ff7@gmail.com>
---
 builtin/log.c           | 2 +-
 t/t4255-am-submodule.sh | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/log.c b/builtin/log.c
index 734aab3..cb14db4 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -705,7 +705,7 @@ static int git_format_config(const char *var, const char *value, void *cb)
 		return 0;
 	}
 	if (!strcmp(var, "diff.color") || !strcmp(var, "color.diff") ||
-	    !strcmp(var, "color.ui")) {
+	    !strcmp(var, "color.ui") || !strcmp(var, "diff.submodule")) {
 		return 0;
 	}
 	if (!strcmp(var, "format.numbered")) {
diff --git a/t/t4255-am-submodule.sh b/t/t4255-am-submodule.sh
index a38c305..27ea698 100755
--- a/t/t4255-am-submodule.sh
+++ b/t/t4255-am-submodule.sh
@@ -78,12 +78,12 @@ test_expect_success 'diff.submodule unset with extra file' '
 	run_test $THIRD second-submodule
 '
 
-test_expect_failure 'diff.submodule=log' '
+test_expect_success 'diff.submodule=log' '
 	test_config diff.submodule log &&
 	run_test $SECOND first-submodule
 '
 
-test_expect_failure 'diff.submodule=log with extra file' '
+test_expect_success 'diff.submodule=log with extra file' '
 	test_config diff.submodule log &&
 	run_test $THIRD second-submodule
 '
-- 
2.0.5
Previous: Doug KellyNext: Doug Kelly
Message 16 of 18 in “Fix issue with format-patch and diff.submodule”
  1. 0/2 Fix issue with format-patch and diff.submoduleDoug Kelly, Dec 26, 2014
  2. 1/2 t4255: test am submodule with diff.submoduleDoug Kelly, Dec 26, 2014
  3. Eric SunshineDec 28, 2014
  4. Doug KellyDec 28, 2014
  5. Junio C HamanoDec 29, 2014
  6. Doug KellyJan 7, 2015
  7. Junio C HamanoJan 7, 2015
  8. 2/2 format-patch: ignore diff.submodule settingDoug Kelly, Dec 26, 2014
  9. 1/2 t4255: test am submodule with diff.submoduleDoug Kelly, Dec 28, 2014
  10. 2/2 format-patch: ignore diff.submodule settingDoug Kelly, Dec 28, 2014
  11. Eric SunshineDec 28, 2014
  12. 1/2 t4255: test am submodule with diff.submoduleDoug Kelly, Jan 7, 2015
  13. 2/2 format-patch: ignore diff.submodule settingDoug Kelly, Jan 7, 2015
  14. Eric SunshineJan 7, 2015
  15. 1/2 t4255: test am submodule with diff.submoduleDoug Kelly, Jan 7, 2015
  16. 2/2 format-patch: ignore diff.submodule settingDoug Kelly, Jan 7, 2015
  17. 1/2 t4255: test am submodule with diff.submoduleDoug Kelly, Jan 7, 2015
  18. 2/2 format-patch: ignore diff.submodule settingDoug Kelly, Jan 7, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.