git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] checkout: pass whole struct to parse_branchname_arg instead of individual flags

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Jan 3, 2015, 09:41 UTC
Message-ID
<1420278087-14613-2-git-send-email-pclouds@gmail.com>
In-Reply-To
<1420278087-14613-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/checkout.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/builtin/checkout.c b/builtin/checkout.c
index 953b763..d8717ef 100644
--- a/builtin/checkout.c
+++ b/builtin/checkout.c
@@ -1079,11 +1079,12 @@ static void check_linked_checkouts(struct branch_info *new)
 static int parse_branchname_arg(int argc, const char **argv,
 				int dwim_new_local_branch_ok,
 				struct branch_info *new,
-				struct tree **source_tree,
-				unsigned char rev[20],
-				const char **new_branch,
-				int force_detach)
+				struct checkout_opts *opts,
+				unsigned char rev[20])
 {
+	struct tree **source_tree = &opts->source_tree;
+	const char **new_branch = &opts->new_branch;
+	int force_detach = opts->force_detach;
 	int argcount = 0;
 	unsigned char branch_rev[20];
 	const char *arg;
@@ -1420,9 +1421,7 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)
 			opts.track == BRANCH_TRACK_UNSPECIFIED &&
 			!opts.new_branch;
 		int n = parse_branchname_arg(argc, argv, dwim_ok,
-					     &new, &opts.source_tree,
-					     rev, &opts.new_branch,
-					     opts.force_detach);
+					     &new, &opts, rev);
 		argv += n;
 		argc -= n;
 	}
-- 
2.2.0.84.ge9c7a8a
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 2 of 14 in “nd/multiple-work-trees updates”
  1. 0/3 nd/multiple-work-trees updatesNguyễn Thái Ngọc Duy, Jan 3, 2015
  2. 1/3 checkout: pass whole struct to parse_branchname_arg instead of individual flagsNguyễn Thái Ngọc Duy, Jan 3, 2015
  3. 2/3 checkout: add --ignore-other-wortreesNguyễn Thái Ngọc Duy, Jan 3, 2015
  4. Mark LevedahlJan 5, 2015
  5. 3/3 git-checkout.txt: a note about multiple checkout support for submodulesNguyễn Thái Ngọc Duy, Jan 3, 2015
  6. Mark LevedahlJan 5, 2015
  7. Max KirillovJan 6, 2015
  8. Junio C HamanoFeb 12, 2015
  9. Jens LehmannFeb 12, 2015
  10. Mark LevedahlFeb 13, 2015
  11. Dennis KaarsemakerFeb 13, 2015
  12. Duy NguyenFeb 13, 2015
  13. Ephrim KhongMar 18, 2015
  14. Duy NguyenMar 18, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.