git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] t2004: drop unnecessary write-tree/read-tree

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Dec 24, 2014, 09:43 UTC
Message-ID
<1419414196-58587-3-git-send-email-sunshine@sunshineco.com>
In-Reply-To
<1419414196-58587-1-git-send-email-sunshine@sunshineco.com>

Unlike earlier tests which reference several trees prepared by "setup", no other tests utilize the tree from the "symlink" test, so there is no need to write it (or read it back immediately).

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---
 t/t2004-checkout-cache-temp.sh | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/t/t2004-checkout-cache-temp.sh b/t/t2004-checkout-cache-temp.sh
index 28e50d6..22d1a24 100755
--- a/t/t2004-checkout-cache-temp.sh
+++ b/t/t2004-checkout-cache-temp.sh
@@ -198,9 +198,6 @@ test_expect_success 'checkout --temp within subdir' '
 test_expect_success 'checkout --temp symlink' '
 	rm -f path* .merge_* actual .git/index &&
 	test_ln_s_add b a &&
-	t4=$(git write-tree) &&
-	rm -f .git/index &&
-	git read-tree $t4 &&
 	git checkout-index --temp -a >actual &&
 	test_line_count = 1 actual &&
 	test $(cut "-d	" -f2 actual) = a &&
-- 
2.2.1.267.g0ad48de
Previous: Eric SunshineNext: Eric Sunshine
Message 3 of 8 in “resolve checkout-index --temp path mangling”
  1. 0/5 resolve checkout-index --temp path manglingEric Sunshine, Dec 24, 2014
  2. 1/5 t2004: modernize styleEric Sunshine, Dec 24, 2014
  3. 2/5 t2004: drop unnecessary write-tree/read-treeEric Sunshine, Dec 24, 2014
  4. 3/5 t2004: standardize file naming in symlink testEric Sunshine, Dec 24, 2014
  5. 4/5 t2004: demonstrate broken relative path printingEric Sunshine, Dec 24, 2014
  6. 5/5 checkout-index: fix --temp relative path manglingEric Sunshine, Dec 24, 2014
  7. Eric SunshineDec 28, 2014
  8. Junio C HamanoDec 29, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.