git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] update_unicode.sh: set UNICODE_DIR only once

From
dev+git@drbeat.li <dev+git@drbeat.li>
Date
Dec 19, 2014, 14:39 UTC
Message-ID
<1418999971-21548-2-git-send-email-dev+git@drbeat.li>
In-Reply-To
<1418999971-21548-1-git-send-email-dev+git@drbeat.li>
From: Beat Bolli <dev+git@drbeat.li>

The value is the same on both uniset invocations, so "Don't Repeat Yourself" applies.

Since we're in a subshell already, there's no need to unset UNICODE_DIR at the end.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
 update_unicode.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/update_unicode.sh b/update_unicode.sh
index c1c876c..bed8916 100755
--- a/update_unicode.sh
+++ b/update_unicode.sh
@@ -27,12 +27,13 @@ fi &&
 		fi &&
 		make
 	) && {
+		UNICODE_DIR=. && export UNICODE_DIR &&
 		echo "static const struct interval zero_width[] = {" &&
-		UNICODE_DIR=. ./uniset/uniset --32 cat:Me,Mn,Cf + U+1160..U+11FF - U+00AD |
+		./uniset/uniset --32 cat:Me,Mn,Cf + U+1160..U+11FF - U+00AD |
 		grep -v plane &&
 		echo "};" &&
 		echo "static const struct interval double_width[] = {" &&
-		UNICODE_DIR=. ./uniset/uniset --32 eaw:F,W &&
+		./uniset/uniset --32 eaw:F,W &&
 		echo "};"
 	} >$UNICODEWIDTH_H
 )
-- 
2.1.3
Previous: dev+git@drbeat.liNext: dev+git@drbeat.li
Message 2 of 9 in “update_unicode.sh: simplify output capture”
  1. 1/5 update_unicode.sh: simplify output capturedev+git@drbeat.li, Dec 19, 2014
  2. 2/5 update_unicode.sh: set UNICODE_DIR only oncedev+git@drbeat.li, Dec 19, 2014
  3. 3/5 update_unicode.sh: shorten uniset invocation pathdev+git@drbeat.li, Dec 19, 2014
  4. 4/5 update_unicode.sh: Make the output structure visibledev+git@drbeat.li, Dec 19, 2014
  5. Jeff KingDec 19, 2014
  6. Beat BolliDec 19, 2014
  7. Jeff KingDec 19, 2014
  8. 5/5 update_unicode.sh: Delete the command groupdev+git@drbeat.li, Dec 19, 2014
  9. Beat BolliDec 19, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.