[PATCH 33/34] checkout: do not fail if target is an empty directory
- From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
- Date
- Nov 30, 2014, 08:24 UTC
- Message-ID
- <1417335899-27307-34-git-send-email-pclouds@gmail.com>
- In-Reply-To
- <1417335899-27307-1-git-send-email-pclouds@gmail.com>
From: Max Kirillov <max@max630.net>
Non-recursive checkout creates empty directpries in place of submodules. If then I try to "checkout --to" submodules there, it refuses to do so, because directory already exists.
Fix by allowing checking out to empty directory. Add test and modify the existing one so that it uses non-empty directory.
Signed-off-by: Max Kirillov <max@max630.net> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> --- builtin/checkout.c | 2 +- t/t2025-checkout-to.sh | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/builtin/checkout.c b/builtin/checkout.c index 8c5276c..953b763 100644 --- a/builtin/checkout.c +++ b/builtin/checkout.c @@ -865,7 +865,7 @@ static int prepare_linked_checkout(const struct checkout_opts *opts, if (!new->commit) die(_("no branch specified")); - if (file_exists(path)) + if (file_exists(path) && !is_empty_dir(path)) die(_("'%s' already exists"), path); len = strlen(path); diff --git a/t/t2025-checkout-to.sh b/t/t2025-checkout-to.sh index eddd325..915b506 100755 --- a/t/t2025-checkout-to.sh +++ b/t/t2025-checkout-to.sh @@ -13,10 +13,15 @@ test_expect_success 'checkout --to not updating paths' ' ' test_expect_success 'checkout --to an existing worktree' ' - mkdir existing && + mkdir -p existing/subtree && test_must_fail git checkout --detach --to existing master ' +test_expect_success 'checkout --to an existing empty worktree' ' + mkdir existing_empty && + git checkout --detach --to existing_empty master +' + test_expect_success 'checkout --to refuses to checkout locked branch' ' test_must_fail git checkout --to zere master && ! test -d zere &&
-- 2.1.0.rc0.78.gc0d8480