Re: 'simple' push check that branch name matches does not work if push.default is unset (and hence implicitly simple)

From: Adam Williamson <awilliam@redhat.com>
Date: Nov 27, 2014, 17:12 UTC
Message-ID: <1417108347.18654.4.camel@redhat.com>
In-Reply-To: <20141127034306.GA5341@peff.net>

On Wed, 2014-11-26 at 22:43 -0500, Jeff King wrote:

Show 26 quoted lines

> On Wed, Nov 26, 2014 at 02:29:28PM -0800, Adam Williamson wrote:
> 
> > Hi, folks. Ran into an unfortunate issue with git which helped me mess
> > up a Fedora package repo today :/
> > 
> > The problem can be reproduced thus:
> > 
> > 1. Create an empty repo, clone it
> > 2. Push its master branch with something in it (just to get started)
> > 3. git branch --track moo origin/master
> > 4. git checkout moo
> > 5. echo moo >> moo && git commit -a -m "create moo"
> > 6. git push
> > ** BUG HAPPENS - CHANGES ARE PUSHED TO origin/master **
> > 7. git config --local push.default simple
> > 8. echo moo2 >> moo && git commit -a -m "update moo"
> > 9. git push
> > ** PUSH IS CORRECTLY REJECTED **
> > 
> > In both those cases, the push behaviour is supposed to be 'simple' - at
> > step 6 it's *implicitly* set to 'simple' (according to the
> > documentation), while at step 9 it's *explicitly* set to 'simple'. At
> > step 6, a warning is printed to the console:
> 
> Ugh. Yeah, this never worked properly, even in the original v2.0.0
> release. Worse, our tests did not notice it at all.  Patch is below.

I've got a pile of Fedora stuff to do today so I don't know if I'll get time to dig any further into the history of this and see if there are any hidden wrinkles, but on the face of it, Jeff's patch looks good to me. I'll try and find a moment to test it at least, but the approach makes sense and is what I would've gone for too.

It might also be worth improving the warn_unspecified_push_default_msg[] text to mention the name matching behaviour? At present it doesn't clearly explain this (you could argue it's *sort of* implied, but I doubt many people will read it that way - I didn't), you have to follow the chain into 'git help config' to find the description. Something like:

   "Since Git 2.0, Git defaults to the more conservative 'simple'\n"
   "behavior, which only pushes the current branch to the corresponding\n"
   "remote branch that 'git pull' uses to update the current branch, \n"
   "if the names of those two branches match.\n"

-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net