Re: [PATCH/RFC 1/2] git-rebase -i: Add key word "drop" to remove a commit
- From
Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
- Date
- May 29, 2015, 08:33 UTC
- Message-ID
- <1416141686.132444.1432888411621.JavaMail.zimbra@ensimag.grenoble-inp.fr>
- In-Reply-To
- <1836557143.132299.1432888016868.JavaMail.zimbra@ensimag.grenoble-inp.fr>
At first we wanted a clear indication about removing a commit in rebase -i. We didn't know about the noop command. - 'noop' does the same thing as 'drop' but for the user deleting a commit through 'noop' doesn't seem to be the proper way to use this command. Moreover 'noop' is not documented (especially it is not shown in the short help that is display in the editor during the rebase -i) - Commenting the line does the same but will cause problems with the second part of the patch (warn about removed commits) because the line is then not taken into consideration.
We wanted to add the 'drop' command because we wanted a way for clearly deleting a commit (and also for the second part of the patch) and there is no clear way so far.