git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 07/16] refs.c: rollback the lockfile before we die() in repack_without_refs

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Nov 7, 2014, 19:38 UTC
Message-ID
<1415389145-6391-8-git-send-email-sahlberg@google.com>
In-Reply-To
<1415389145-6391-1-git-send-email-sahlberg@google.com>
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 refs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/refs.c b/refs.c
index 9a3c7fe..5a8f3da 100644
--- a/refs.c
+++ b/refs.c
@@ -2707,8 +2707,10 @@ int repack_without_refs(struct string_list *without, struct strbuf *err)
 	/* Remove any other accumulated cruft */
 	do_for_each_entry_in_dir(packed, 0, curate_packed_ref_fn, &refs_to_delete);
 	for_each_string_list_item(ref_to_delete, &refs_to_delete) {
-		if (remove_entry(packed, ref_to_delete->string) == -1)
+		if (remove_entry(packed, ref_to_delete->string) == -1) {
+			rollback_packed_refs();
 			die("internal error");
+		}
 	}
 
 	/* Write what remains */
-- 
2.1.0.rc2.206.gedb03e5
Previous: Ronnie SahlbergNext: Ronnie Sahlberg
Message 8 of 17 in “ref-transaction-rename”
  1. 00/16 ref-transaction-renameRonnie Sahlberg, Nov 7, 2014
  2. 01/16 refs.c: allow passing raw git_committer_info as email to _update_reflogRonnie Sahlberg, Nov 7, 2014
  3. 02/16 refs.c: return error instead of dying when locking fails during transactionRonnie Sahlberg, Nov 7, 2014
  4. 03/16 refs.c: use packed refs when deleting refs during a transactionRonnie Sahlberg, Nov 7, 2014
  5. 04/16 refs.c: use a stringlist for repack_without_refsRonnie Sahlberg, Nov 7, 2014
  6. 05/16 refs.c: add transaction support for renaming a reflogRonnie Sahlberg, Nov 7, 2014
  7. 06/16 refs.c: update rename_ref to use a transactionRonnie Sahlberg, Nov 7, 2014
  8. 07/16 refs.c: rollback the lockfile before we die() in repack_without_refsRonnie Sahlberg, Nov 7, 2014
  9. 08/16 refs.c: move reflog updates into its own functionRonnie Sahlberg, Nov 7, 2014
  10. 09/16 refs.c: write updates to packed refs when a transaction has more than one refRonnie Sahlberg, Nov 7, 2014
  11. 10/16 remote.c: use a transaction for deleting refsRonnie Sahlberg, Nov 7, 2014
  12. 11/16 refs.c: make repack_without_refs staticRonnie Sahlberg, Nov 7, 2014
  13. 12/16 refs.c: make the *_packed_refs functions staticRonnie Sahlberg, Nov 7, 2014
  14. 13/16 refs.c: replace the onerr argument in update_ref with a strbuf errRonnie Sahlberg, Nov 7, 2014
  15. 14/16 refs.c: make add_packed_ref return an error instead of calling dieRonnie Sahlberg, Nov 7, 2014
  16. 15/16 refs.c: make lock_packed_refs take an err argumentRonnie Sahlberg, Nov 7, 2014
  17. 16/16 refs.c: add an err argument to pack_refsRonnie Sahlberg, Nov 7, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.