git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 00/15] ref-transactions-reflog

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Nov 3, 2014, 16:55 UTC
Message-ID
<1415033757-9539-1-git-send-email-sahlberg@google.com>
List,

Please find a patch that updates the reflog handling to use transactions. This patch series has previously been sent to the list but is now rebased on the current content of next which contains ref changes we depend on in this series.

This series converts the reflog handling and builtin/reflog.c to use a transaction for both the ref as well as the reflog updates. As a side effect of this it simplifies the reflog marshalling code so that we only have one place where we marshall the entry. It also means that we can remove several functions from the public api towards the end of the series since we no longer need those functions.

This series can also be found at https://github.com/rsahlberg/git/tree/ref-transactions-reflog

Version 2:
- Clarify the commit message to refs.c: only write reflog update if msg is
  non-NULL to highlight that msg==NULL and REFLOG_TRUNCATE control othogonal
  features.
- Improve the comments for the transaction flags field in refs.c: allow
  multiple reflog updates during a single transaction.
Ronnie Sahlberg (15):
  refs.c make ref_transaction_create a wrapper to ref_transaction_update
  refs.c: make ref_transaction_delete a wrapper for
    ref_transaction_update
  refs.c: rename the transaction functions
  refs.c: add a new update_type field to ref_update
  refs.c: add a function to append a reflog entry to a fd
  copy.c: make copy_fd preserve meaningful errno
  refs.c: add a transaction function to append a reflog entry
  refs.c: add a flag to allow reflog updates to truncate the log
  refs.c: only write reflog update if msg is non-NULL
  refs.c: allow multiple reflog updates during a single transaction
  reflog.c: use a reflog transaction when writing during expire
  refs.c: rename log_ref_setup to create_reflog
  refs.c: make unlock_ref/close_ref/commit_ref static
  refs.c: remove lock_any_ref_for_update
  refs.c: allow deleting refs with a broken sha1
 branch.c                    |  14 +-
 builtin/branch.c            |   5 +-
 builtin/checkout.c          |   8 +-
 builtin/commit.c            |  10 +-
 builtin/fetch.c             |  12 +-
 builtin/receive-pack.c      |  13 +-
 builtin/reflog.c            |  85 ++++------
 builtin/replace.c           |  10 +-
 builtin/tag.c               |  10 +-
 builtin/update-ref.c        |  26 +--
 cache.h                     |   7 +
 copy.c                      |  15 +-
 fast-import.c               |  22 +--
 refs.c                      | 403 +++++++++++++++++++++++++++++---------------
 refs.h                      |  87 +++++-----
 sequencer.c                 |  12 +-
 t/t1402-check-ref-format.sh |   8 +
 walker.c                    |  10 +-
 18 files changed, 450 insertions(+), 307 deletions(-)
-- 
2.1.0.rc2.206.gedb03e5
Next: Ronnie Sahlberg
Message 1 of 16 in “ref-transactions-reflog”
  1. 00/15 ref-transactions-reflogRonnie Sahlberg, Nov 3, 2014
  2. 01/15 refs.c make ref_transaction_create a wrapper to ref_transaction_updateRonnie Sahlberg, Nov 3, 2014
  3. 02/15 refs.c: make ref_transaction_delete a wrapper for ref_transaction_updateRonnie Sahlberg, Nov 3, 2014
  4. 03/15 refs.c: rename the transaction functionsRonnie Sahlberg, Nov 3, 2014
  5. 04/15 refs.c: add a new update_type field to ref_updateRonnie Sahlberg, Nov 3, 2014
  6. 05/15 refs.c: add a function to append a reflog entry to a fdRonnie Sahlberg, Nov 3, 2014
  7. 06/15 copy.c: make copy_fd preserve meaningful errnoRonnie Sahlberg, Nov 3, 2014
  8. 07/15 refs.c: add a transaction function to append a reflog entryRonnie Sahlberg, Nov 3, 2014
  9. 08/15 refs.c: add a flag to allow reflog updates to truncate the logRonnie Sahlberg, Nov 3, 2014
  10. 09/15 refs.c: only write reflog update if msg is non-NULLRonnie Sahlberg, Nov 3, 2014
  11. 10/15 refs.c: allow multiple reflog updates during a single transactionRonnie Sahlberg, Nov 3, 2014
  12. 11/15 reflog.c: use a reflog transaction when writing during expireRonnie Sahlberg, Nov 3, 2014
  13. 12/15 refs.c: rename log_ref_setup to create_reflogRonnie Sahlberg, Nov 3, 2014
  14. 13/15 refs.c: make unlock_ref/close_ref/commit_ref staticRonnie Sahlberg, Nov 3, 2014
  15. 14/15 refs.c: remove lock_any_ref_for_updateRonnie Sahlberg, Nov 3, 2014
  16. 15/15 refs.c: allow deleting refs with a broken sha1Ronnie Sahlberg, Nov 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.