git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/4] builtin/merge.c: drop a parameter that is never used

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 28, 2014, 21:36 UTC
Message-ID
<1414532212-9016-2-git-send-email-gitster@pobox.com>
In-Reply-To
<1414532212-9016-1-git-send-email-gitster@pobox.com>

Since the very beginning when we added the "renormalizing" parameter to this function with 7610fa57 (merge-recursive --renormalize, 2010-08-05), nobody seems to have ever referenced it.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/merge.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/merge.c b/builtin/merge.c
index 41fb66d..f6894c7 100644
--- a/builtin/merge.c
+++ b/builtin/merge.c
@@ -884,7 +884,7 @@ static int finish_automerge(struct commit *head,
 	return 0;
 }
 
-static int suggest_conflicts(int renormalizing)
+static int suggest_conflicts(void)
 {
 	const char *filename;
 	FILE *fp;
@@ -1557,7 +1557,7 @@ int cmd_merge(int argc, const char **argv, const char *prefix)
 		fprintf(stderr, _("Automatic merge went well; "
 			"stopped before committing as requested\n"));
 	else
-		ret = suggest_conflicts(option_renormalize);
+		ret = suggest_conflicts();
 
 done:
 	free(branch_to_free);
-- 
2.1.2-620-g33c52cb
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 5 in “Turning Conflicts: hint into comment”
  1. 0/4 Turning Conflicts: hint into commentJunio C Hamano, Oct 28, 2014
  2. 1/4 builtin/merge.c: drop a parameter that is never usedJunio C Hamano, Oct 28, 2014
  3. 2/4 merge & sequencer: unify codepaths that write "Conflicts:" hintJunio C Hamano, Oct 28, 2014
  4. 3/4 builtin/commit.c: extract ignore_non_trailer() helper functionJunio C Hamano, Oct 28, 2014
  5. 4/4 merge & sequencer: turn "Conflicts:" hint into a commentJunio C Hamano, Oct 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.