git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: remove unnecessary DESTROY override

From
EWEric Wong <normalperson@yhbt.net>
Date
Oct 25, 2014, 08:01 UTC
Message-ID
<1414224094-32499-1-git-send-email-normalperson@yhbt.net>

This override was probably never necessary, but most likely a no-op as it does not appear to do anything in SVN::Ra itself.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 perl/Git/SVN/Ra.pm | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
index 1828519..e326849 100644
--- a/perl/Git/SVN/Ra.pm
+++ b/perl/Git/SVN/Ra.pm
@@ -177,10 +177,6 @@ sub get_dir {
 	wantarray ? (\%dirents, $r, $props) : \%dirents;
 }
 
-sub DESTROY {
-	# do not call the real DESTROY since we store ourselves in $RA
-}
-
 # get_log(paths, start, end, limit,
 #         discover_changed_paths, strict_node_history, receiver)
 sub get_log {
-- 
EW
Message 1 of 1 in “git-svn: remove unnecessary DESTROY override”
  1. git-svn: remove unnecessary DESTROY overrideEric Wong, Oct 25, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.