[RFC PATCH 1/1] json-writer: incorrect format specifier
- From
Wink Saville <wink@saville.com>
- Date
- Mar 24, 2018, 05:37 UTC
- Message-ID
- <140b7646e7efa4175f9d82e6eb2909f2f94771fe.1521868951.git.wink@saville.com>
- In-Reply-To
- <cover.1521868951.git.wink@saville.com>
In routines jw_object_uint64 and jw_object_double strbuf_addf is invoked with strbuf_addf(&jw->json, ":%"PRIuMAX, value) where value is a uint64_t. This causes a compile error on OSX.
The correct format specifier is PRIu64 instead of PRIuMax.
Signed-off-by: Wink Saville <wink@saville.com> --- json-writer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/json-writer.c b/json-writer.c index 89a6abb57..04045448a 100644 --- a/json-writer.c +++ b/json-writer.c @@ -120,7 +120,7 @@ void jw_object_uint64(struct json_writer *jw, const char *key, uint64_t value) maybe_add_comma(jw); append_quoted_string(&jw->json, key); - strbuf_addf(&jw->json, ":%"PRIuMAX, value); + strbuf_addf(&jw->json, ":%"PRIu64, value); } void jw_object_double(struct json_writer *jw, const char *fmt, @@ -225,7 +225,7 @@ void jw_array_uint64(struct json_writer *jw, uint64_t value) assert_in_array(jw); maybe_add_comma(jw); - strbuf_addf(&jw->json, "%"PRIuMAX, value); + strbuf_addf(&jw->json, "%"PRIu64, value); } void jw_array_double(struct json_writer *jw, const char *fmt, double value)
-- 2.16.2