[PATCH v4 12/32] prepare_index(): declare return value to be (const char *)
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Sep 6, 2014, 07:50 UTC
- Message-ID
- <1409989846-22401-13-git-send-email-mhagger@alum.mit.edu>
- In-Reply-To
- <1409989846-22401-1-git-send-email-mhagger@alum.mit.edu>
Declare the return value to be const to make it clear that we aren't giving callers permission to write over the string that it points at. (The return value is the filename field of a struct lock_file, which can be used by a signal handler at any time and therefore shouldn't be tampered with.)
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- builtin/commit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/commit.c b/builtin/commit.c index a3eaf4b..046be7e 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -315,8 +315,8 @@ static void refresh_cache_or_die(int refresh_flags) die_resolve_conflict("commit"); } -static char *prepare_index(int argc, const char **argv, const char *prefix, - const struct commit *current_head, int is_status) +static const char *prepare_index(int argc, const char **argv, const char *prefix, + const struct commit *current_head, int is_status) { struct string_list partial; struct pathspec pathspec;
-- 2.1.0