git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re[2]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

From
IBIlya Basin <basinilya@gmail.com>
Date
May 1, 2013, 08:31 UTC
Message-ID
<1409591910.20130501123153@gmail.com>
In-Reply-To
<1438528085.20130501090926@gmail.com>

IB> In my repo the placeholders change too often (in 1/4 commits). I'm IB> thinking of using: IB> 'git config --unset "svn-remote.$repo_id.added-placeholder" path_regex' IB> instead of full rewrite.

I need your help. There are still problems:
    $ grep "define MAX_MATCHES" ~/builds/git/git-git/config.c
    #define MAX_MATCHES 8192
    $ grep added-placeholder .git/config | wc -l
    4430

1/4 commits change the list of placeholders, usually 1 folder changes. Clearing and re-adding the entries to the config takes ~1 minute. Pressing Ctrl-C at this time makes the list incomplete.

Re-adding all entries using 'config --add' is slow. Does Git::config package have tools to modify multiple entries at once? I wonder why 'git config --get-all' is used instead of some Git::config routine.

Otherwise, to make this atomic, I think, the modification should be made to a backup config file, then it should replace .git/config (or rewrite it with signals blocked).

How to determine GIT_DIR from Fetcher.pm?

maybe I can simply append a duplicate section '[svn-remote "svn"]'. But then I would need to escape the values myself.

Also, git --unset-all leaves one empty section: '[svn-remote "svn"]' Is it a bug?

Previous: Ilya BasinNext: Junio C Hamano
Message 2 of 18 in “Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()”
  1. Ilya BasinMay 1, 2013
  2. Re[2]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()Ilya Basin, May 1, 2013
  3. Junio C HamanoMay 1, 2013
  4. Re[2]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()Ilya Basin, May 1, 2013
  5. Eric WongMay 1, 2013
  6. Junio C HamanoMay 1, 2013
  7. Eric WongMay 2, 2013
  8. Re[2]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()Ilya Basin, May 2, 2013
  9. Eric WongMay 2, 2013
  10. Re[2]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()Ilya Basin, May 3, 2013
  11. Re[3]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()Ilya Basin, May 3, 2013
  12. Re[4]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()Ilya Basin, May 6, 2013
  13. Re[3]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()Ilya Basin, May 6, 2013
  14. Eric WongMay 9, 2013
  15. Re[4]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()Ilya Basin, May 28, 2013
  16. Ray ChenMay 2, 2013
  17. Re[2]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()Ilya Basin, May 2, 2013
  18. Eric WongMay 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.