git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval

From
Keller, Jacob E <jacob.e.keller@intel.com>
Date
Aug 29, 2014, 16:48 UTC
Message-ID
<1409330916.18778.17.camel@jekeller-desk1.amr.corp.intel.com>
In-Reply-To
<1409330561-11806-1-git-send-email-jacob.e.keller@intel.com>
On Fri, 2014-08-29 at 09:42 -0700, Jacob Keller wrote:
Show 11 quoted lines
> From: Jonas 'Sortie' Termansen <sortie@maxsi.org>
> 
> This hasn't been a problem in practice as almost all systems have the
> setitimer() API (or it is provided by git in the case of mingw). This code
> wasn't used in any default circumstances, as the build system never sets
> NO_STRUCT_ITIMERVAL - this breakage only occured if the user asked for it.
> 
> We repair this case so we can rely on it in the following commits.
> 
> Signed-off-by: Jonas 'Sortie' Termansen <sortie@maxsi.org>
> ---

I fixed up Jonas' series and tried to resolve the issues I found as well as re-ordered the patches so that they fit what Junio requested. I also modified the last two patches to make timer_settime fallback to setitimer. I am not sure this is the best approach, but it should be easy to take at least the obvious bug fixes from the first three patches, and this gives an outline for how we could wrap the setitimer stuff.

One could also write another layer of wrapper in some compat/itimer.c code, but I don't think this is necessary.

Regards, Jake

Previous: Junio C HamanoNext: Jonas 'Sortie' Termansen
Message 19 of 23 in “git-compat-util.h: Add missing semicolon after struct itimerval”
  1. 1/9 git-compat-util.h: Add missing semicolon after struct itimervalJacob Keller, Aug 29, 2014
  2. 2/9 autoconf: Check for struct itimervalJacob Keller, Aug 29, 2014
  3. 3/9 autoconf: Check for setitimerJacob Keller, Aug 29, 2014
  4. 4/9 autoconf: Check for timer_tJacob Keller, Aug 29, 2014
  5. Jonas 'Sortie' TermansenAug 29, 2014
  6. 5/9 autoconf: Check for struct timespecJacob Keller, Aug 29, 2014
  7. 6/9 autoconf: Check for struct sigeventJacob Keller, Aug 29, 2014
  8. 7/9 autoconf: Check for struct itimerspecJacob Keller, Aug 29, 2014
  9. 8/9 autoconf: Check for timer_settimeJacob Keller, Aug 29, 2014
  10. Johannes SixtAug 29, 2014
  11. Keller, Jacob EAug 29, 2014
  12. Karsten BleesSep 10, 2014
  13. Junio C HamanoSep 10, 2014
  14. Keller, Jacob ESep 10, 2014
  15. 9/9 Use timer_settime for new platformsJacob Keller, Aug 29, 2014
  16. Junio C HamanoAug 29, 2014
  17. Keller, Jacob EAug 29, 2014
  18. Junio C HamanoAug 29, 2014
  19. Keller, Jacob EAug 29, 2014
  20. Jonas 'Sortie' TermansenAug 29, 2014
  21. Junio C HamanoAug 29, 2014
  22. Jonas 'Sortie' TermansenAug 29, 2014
  23. Keller, Jacob ESep 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.