git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] clone.c: don't leak memory in cmd_clone

From
Stefan Beller <stefanbeller@gmail.com>
Date
Aug 10, 2014, 13:57 UTC
Message-ID
<1407679076-20300-2-git-send-email-stefanbeller@gmail.com>
In-Reply-To
<1407679076-20300-1-git-send-email-stefanbeller@gmail.com>

Free the refspec. Found by scan.coverity.com (Id: 1127806)

Signed-off-by: Stefan Beller <stefanbeller@gmail.com>
---
 builtin/clone.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/builtin/clone.c b/builtin/clone.c
index bbd169c..dd4092b 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -1004,5 +1004,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
 	strbuf_release(&key);
 	strbuf_release(&value);
 	junk_mode = JUNK_LEAVE_ALL;
+
+	free(refspec);
 	return err;
 }
-- 
2.1.0.rc2
Previous: Stefan BellerNext: Stefan Beller
Message 2 of 6 in “remote.c: don't leak the base branch name in format_tracking_info”
  1. 1/2 remote.c: don't leak the base branch name in format_tracking_infoStefan Beller, Aug 10, 2014
  2. 2/2 clone.c: don't leak memory in cmd_cloneStefan Beller, Aug 10, 2014
  3. Stefan BellerAug 10, 2014
  4. Jeff KingAug 10, 2014
  5. remote.c: don't leak the base branch name in format_tracking_infoStefan Beller, Aug 10, 2014
  6. Junio C HamanoAug 10, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.