[PATCH v2 04/11] archive.c: replace `git_config()` with `git_config_get_bool()` family
- From
Tanay Abhra <tanayabh@gmail.com>
- Date
- Aug 7, 2014, 16:21 UTC
- Message-ID
- <1407428486-19049-5-git-send-email-tanayabh@gmail.com>
- In-Reply-To
- <1407428486-19049-1-git-send-email-tanayabh@gmail.com>
Use `git_config_get_bool()` family instead of `git_config()` to take advantage of the config-set API which provides a cleaner control flow.
Signed-off-by: Tanay Abhra <tanayabh@gmail.com> --- archive.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/archive.c b/archive.c index 3fc0fb2..952a659 100644 --- a/archive.c +++ b/archive.c @@ -402,14 +402,6 @@ static int parse_archive_args(int argc, const char **argv, return argc; } -static int git_default_archive_config(const char *var, const char *value, - void *cb) -{ - if (!strcmp(var, "uploadarchive.allowunreachable")) - remote_allow_unreachable = git_config_bool(var, value); - return git_default_config(var, value, cb); -} - int write_archive(int argc, const char **argv, const char *prefix, int setup_prefix, const char *name_hint, int remote) { @@ -420,7 +412,9 @@ int write_archive(int argc, const char **argv, const char *prefix, if (setup_prefix && prefix == NULL) prefix = setup_git_directory_gently(&nongit); - git_config(git_default_archive_config, NULL); + git_config_get_bool("uploadarchive.allowunreachable", &remote_allow_unreachable); + git_config(git_default_config, NULL); + init_tar_archiver(); init_zip_archiver();
-- 1.9.0.GIT