git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 00/11] git_config callers rewritten with the new config-set API

From
Tanay Abhra <tanayabh@gmail.com>
Date
Aug 4, 2014, 18:33 UTC
Message-ID
<1407177229-30081-1-git-send-email-tanayabh@gmail.com>
The ta/config-set API is more or less solidified.

This series builds on the top of 4c715ebb in pu (ta/config-set). On top of it, it also requires series [1] (Rewrite `git_config()` using config-set API) for proper error checking.

This series is the first batch of patches which rewrites the existing callers using a non-callback approach. This series aims to,

* rewrite the existing callers, as you can see from the diff stat the bew API
  provides a much concise and clear control flow.
* stress test the new API, see if any corner cases or deficiencies arise or not.

The series passes all the tests, only thing to watch is that the config variables that have been rewritten are single valued only. Though I have tried my best to ascertain it, still mistakes may arise.

p.s: I haven't decided yet about whether to introduce a new helper set, for example
     git_config_get_value_fmt() which would behave like strbuf_addf(). It will probably
     come in a later series.
[1]: http://thread.gmane.org/gmane.comp.version-control.git/254633/
Tanay Abhra (11):
 alias.c        | 25 ++++++------------------
 archive.c      | 12 +++---------
 branch.c       | 27 +++++++-------------------
 builtin/gc.c   | 51 +++++++++++++++++++-----------------------------
 daemon.c       | 27 +++++---------------------
 fetch-pack.c   | 35 ++++++++-------------------------
 http-backend.c | 31 ++++++++++++-----------------
 imap-send.c    | 61 ++++++++++++++++++++++++++--------------------------------
 pager.c        | 40 +++++++++++++-------------------------
 read-cache.c   | 14 +++-----------
 rerere.c       | 43 ++++++++++++-----------------------------
 11 files changed, 116 insertions(+), 250 deletions(-)
-- 
1.9.0.GIT
Next: Tanay Abhra
Message 1 of 20 in “git_config callers rewritten with the new config-set API”
  1. 00/11 git_config callers rewritten with the new config-set APITanay Abhra, Aug 4, 2014
  2. 01/11 daemon.c: replace `git_config()` with `git_config_get_bool()` familyTanay Abhra, Aug 4, 2014
  3. Matthieu MoyAug 4, 2014
  4. 02/11 http-backend.c: replace `git_config()` with `git_config_get_bool()` familyTanay Abhra, Aug 4, 2014
  5. Eric SunshineAug 4, 2014
  6. Tanay AbhraAug 6, 2014
  7. Matthieu MoyAug 6, 2014
  8. Eric SunshineAug 6, 2014
  9. 03/11 read-cache.c: replace `git_config()` with `git_config_get_*()` familyTanay Abhra, Aug 4, 2014
  10. 04/11 archive.c: replace `git_config()` with `git_config_get_bool()` familyTanay Abhra, Aug 4, 2014
  11. 05/11 fetchpack.c: replace `git_config()` with `git_config_get_*()` familyTanay Abhra, Aug 4, 2014
  12. 06/11 rerere.c: replace `git_config()` with `git_config_get_*()` familyTanay Abhra, Aug 4, 2014
  13. 07/11 builtin/gc.c: replace `git_config()` with `git_config_get_*()` familyTanay Abhra, Aug 4, 2014
  14. Matthieu MoyAug 4, 2014
  15. 08/11 pager.c: replace `git_config()` with `git_config_get_value()`Tanay Abhra, Aug 4, 2014
  16. Matthieu MoyAug 4, 2014
  17. 09/11 imap-send.c: replace `git_config()` with `git_config_get_*()` familyTanay Abhra, Aug 4, 2014
  18. 10/11 alias.c: replace `git_config()` with `git_config_get_string()`Tanay Abhra, Aug 4, 2014
  19. 11/11 branch.c: replace `git_config()` with `git_config_get_string()Tanay Abhra, Aug 4, 2014
  20. Matthieu MoyAug 4, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.