git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/5] refs.c: rollback the lockfile before we die() in repack_without_refs

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Jul 25, 2014, 16:58 UTC
Message-ID
<1406307521-10339-6-git-send-email-sahlberg@google.com>
In-Reply-To
<1406307521-10339-1-git-send-email-sahlberg@google.com>
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
 refs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/refs.c b/refs.c
index a5053bf..619725a 100644
--- a/refs.c
+++ b/refs.c
@@ -2570,8 +2570,10 @@ int repack_without_refs(const char **refnames, int n, struct strbuf *err)
 	/* Remove any other accumulated cruft */
 	do_for_each_entry_in_dir(packed, 0, curate_packed_ref_fn, &refs_to_delete);
 	for_each_string_list_item(ref_to_delete, &refs_to_delete) {
-		if (remove_entry(packed, ref_to_delete->string) == -1)
+		if (remove_entry(packed, ref_to_delete->string) == -1) {
+			rollback_packed_refs();
 			die("internal error");
+		}
 	}
 
 	/* Write what remains */
-- 
2.0.1.508.g763ab16
Previous: Jonathan Nieder
Message 13 of 13 in “ref-transactions-rename”
  1. 0/5 ref-transactions-renameRonnie Sahlberg, Jul 25, 2014
  2. 1/5 refs.c: allow passing raw git_committer_info as email to _update_reflogRonnie Sahlberg, Jul 25, 2014
  3. Jonathan NiederJul 25, 2014
  4. Ronnie SahlbergJul 28, 2014
  5. Eric SunshineJul 28, 2014
  6. 2/5 refs.c: return error instead of dying when locking fails during transactionRonnie Sahlberg, Jul 25, 2014
  7. Jonathan NiederJul 25, 2014
  8. Ronnie SahlbergJul 28, 2014
  9. 3/5 refs.c: use packed refs when deleting refs during a transactionRonnie Sahlberg, Jul 25, 2014
  10. Jonathan NiederJul 25, 2014
  11. 4/5 refs.c: update rename_ref to use a transactionRonnie Sahlberg, Jul 25, 2014
  12. Jonathan NiederJul 25, 2014
  13. 5/5 refs.c: rollback the lockfile before we die() in repack_without_refsRonnie Sahlberg, Jul 25, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.