git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/6] Rewrite `git_config()` using config-set API

From
Tanay Abhra <tanayabh@gmail.com>
Date
Jul 25, 2014, 12:58 UTC
Message-ID
<1406293095-15920-1-git-send-email-tanayabh@gmail.com>
[PATCH V2]: All the suggestions in [2] incorporated. git_config() now follows
	correct parsing order. Reordered the patches. Removed xfuncname patch
	as it was unnecssary.

This series builds on the top of 1d2856f (ta/config-set) in pu or topic[1] in the mailing list with name "git config cache & special querying API utilizing the cache".

This series aims to do these three things,
* Use the config-set API to rewrite git_config().
* Solve any legacy bugs in the previous system while at it.
* To be feature complete compared to the previous git_config() implementation,
  which I think it is now. (added the line number and file name info just for
  completeness)

Also, I haven't yet checked the exact improvements but still as a teaser, git status now only rereads the configuration files twice instead of four times.

[1]: http://thread.gmane.org/gmane.comp.version-control.git/253862 [2]: http://thread.gmane.org/gmane.comp.version-control.git/254101

Tanay Abhra (6):
  config.c: fix accuracy of line number in errors
  add line number and file name info to `config_set`
  rewrite git_config() to use the config-set API
  add a test for semantic errors in config files
  config: add `git_die_config()` to the config-set API
  Add tests for `git_config_get_string()`
 Documentation/technical/api-config.txt |   5 ++
 cache.h                                |  26 +++++++
 config.c                               | 135 ++++++++++++++++++++++++++++-----
 t/t1308-config-set.sh                  |  20 +++++
 test-config.c                          |  10 +++
 5 files changed, 175 insertions(+), 21 deletions(-)
-- 
1.9.0.GIT
Next: Tanay Abhra
Message 1 of 12 in “Rewrite `git_config()` using config-set API”
  1. 0/6 Rewrite `git_config()` using config-set APITanay Abhra, Jul 25, 2014
  2. 1/6 config.c: fix accuracy of line number in errorsTanay Abhra, Jul 25, 2014
  3. 2/6 add line number and file name info to `config_set`Tanay Abhra, Jul 25, 2014
  4. 3/6 rewrite git_config() to use the config-set APITanay Abhra, Jul 25, 2014
  5. Matthieu MoyJul 25, 2014
  6. Tanay AbhraJul 25, 2014
  7. 4/6 add a test for semantic errors in config filesTanay Abhra, Jul 25, 2014
  8. 5/6 config: add `git_die_config()` to the config-set APITanay Abhra, Jul 25, 2014
  9. Matthieu MoyJul 25, 2014
  10. Tanay AbhraJul 25, 2014
  11. Junio C HamanoJul 25, 2014
  12. 6/6 Add tests for `git_config_get_string()`Tanay Abhra, Jul 25, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.