git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 14/15] refs.c: remove lock_any_ref_for_update

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Jul 23, 2014, 17:03 UTC
Message-ID
<1406135035-26441-15-git-send-email-sahlberg@google.com>
In-Reply-To
<1406135035-26441-1-git-send-email-sahlberg@google.com>
No one is using this function so we can delete it.
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
 refs.c |  7 -------
 refs.h | 10 +---------
 2 files changed, 1 insertion(+), 16 deletions(-)
diff --git a/refs.c b/refs.c
index b74e5ff..0ead11f 100644
--- a/refs.c
+++ b/refs.c
@@ -2222,13 +2222,6 @@ static struct ref_lock *lock_ref_sha1_basic(const char *refname,
 	return NULL;
 }
 
-struct ref_lock *lock_any_ref_for_update(const char *refname,
-					 const unsigned char *old_sha1,
-					 int flags, int *type_p)
-{
-	return lock_ref_sha1_basic(refname, old_sha1, flags, type_p, NULL, 0);
-}
-
 /*
  * Write an entry to the packed-refs file for the specified refname.
  * If peeled is non-NULL, write it as the entry's peeled value.
diff --git a/refs.h b/refs.h
index 65d6360..712fc32 100644
--- a/refs.h
+++ b/refs.h
@@ -171,21 +171,13 @@ extern int ref_exists(const char *);
 extern int peel_ref(const char *refname, unsigned char *sha1);
 
 /*
- * Flags controlling lock_any_ref_for_update(), transaction_update_sha1(),
- * transaction_create_sha1(), etc.
+ * Flags controlling transaction_update_sha1(), transaction_create_sha1(), etc.
  * REF_NODEREF: act on the ref directly, instead of dereferencing
  *              symbolic references.
  *
  * Flags >= 0x100 are reserved for internal use.
  */
 #define REF_NODEREF	0x01
-/*
- * Locks any ref (for 'HEAD' type refs) and sets errno to something
- * meaningful on failure.
- */
-extern struct ref_lock *lock_any_ref_for_update(const char *refname,
-						const unsigned char *old_sha1,
-						int flags, int *type_p);
 
 /** Reads log for the value of ref during at_time. **/
 extern int read_ref_at(const char *refname, unsigned long at_time, int cnt,
-- 
2.0.1.508.g763ab16
Previous: Ronnie SahlbergNext: Ronnie Sahlberg
Message 16 of 19 in “ref-transactions for reflogs”
  1. 00/15 ref-transactions for reflogsRonnie Sahlberg, Jul 23, 2014
  2. 01/15 refs.c make ref_transaction_create a wrapper to ref_transaction_updateRonnie Sahlberg, Jul 23, 2014
  3. Junio C HamanoJul 23, 2014
  4. 02/15 refs.c: make ref_transaction_delete a wrapper for ref_transaction_updateRonnie Sahlberg, Jul 23, 2014
  5. 03/15 refs.c: rename the transaction functionsRonnie Sahlberg, Jul 23, 2014
  6. 04/15 refs.c: add a new update_type field to ref_updateRonnie Sahlberg, Jul 23, 2014
  7. 05/15 refs.c: add a function to append a reflog entry to a fdRonnie Sahlberg, Jul 23, 2014
  8. 06/15 lockfile.c: make hold_lock_file_for_append preserve meaningful errnoRonnie Sahlberg, Jul 23, 2014
  9. 07/15 refs.c: add a transaction function to append a reflog entryRonnie Sahlberg, Jul 23, 2014
  10. 08/15 refs.c: add a flag to allow reflog updates to truncate the logRonnie Sahlberg, Jul 23, 2014
  11. 09/15 refs.c: only write reflog update if msg is non-NULLRonnie Sahlberg, Jul 23, 2014
  12. 10/15 refs.c: allow multiple reflog updates during a single transactionRonnie Sahlberg, Jul 23, 2014
  13. 11/15 reflog.c: use a reflog transaction when writing during expireRonnie Sahlberg, Jul 23, 2014
  14. 12/15 refs.c: rename log_ref_setup to create_reflogRonnie Sahlberg, Jul 23, 2014
  15. 13/15 refs.c: make unlock_ref/close_ref/commit_ref staticRonnie Sahlberg, Jul 23, 2014
  16. 14/15 refs.c: remove lock_any_ref_for_updateRonnie Sahlberg, Jul 23, 2014
  17. 15/15 refs.c: allow deleting refs with a broken sha1Ronnie Sahlberg, Jul 23, 2014
  18. Eric SunshineJul 23, 2014
  19. Junio C HamanoJul 23, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.