[PATCH v3 0/6] git_config callers rewritten with the new config cache API
- From
Tanay Abhra <tanayabh@gmail.com>
- Date
- Jul 21, 2014, 11:12 UTC
- Message-ID
- <1405941145-12120-1-git-send-email-tanayabh@gmail.com>
[PATCH v3]: Most of Eric's suggestions has been implemented. See [2] for discussion. Also, new helpers introduced in v7 of the config-set API series have been used. See [1] for the documentation of the new functions.
This series builds on the top of 5def4132 in pu or topic[1] in the mailing list with name "git config cache & special querying API utilizing the cache".
All patches pass every test, but there is a catch, there is slight behaviour change in most of them where originally the callback returns config_error_nonbool() when it sees a NULL value for a key causing a die specified in git_parse_source in config.c.
The die also prints the file name and the line number as,
"die("bad config file line %d in %s", cf->linenr, cf->name);"We lose the fine grained error checking when switching to this method. Still, I will try to correct this anomaly in my next series.
[1]: http://thread.gmane.org/gmane.comp.version-control.git/253862 [2]: http://thread.gmane.org/gmane.comp.version-control.git/252334
Tanay Abhra (6):
alias.c | 27 +++++++-------------------- branch.c | 24 ++++-------------------- imap-send.c | 41 +++++++++++++++-------------------------- notes-utils.c | 33 ++++++++++++++++----------------- notes.c | 21 +++++++-------------- pager.c | 40 +++++++++++++--------------------------- 6 files changed, 62 insertions(+), 124 deletions(-)
-- 1.9.0.GIT