git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v21 11/19] refs.c: make remove_empty_directories always set errno to something sane

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Jul 14, 2014, 20:58 UTC
Message-ID
<1405371541-32121-12-git-send-email-sahlberg@google.com>
In-Reply-To
<1405371541-32121-1-git-send-email-sahlberg@google.com>

Making errno when returning from remove_empty_directories() more obviously meaningful, which should provide some peace of mind for people auditing lock_ref_sha1_basic.

Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 refs.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/refs.c b/refs.c
index a48f805..cc69581 100644
--- a/refs.c
+++ b/refs.c
@@ -1960,14 +1960,16 @@ static int remove_empty_directories(const char *file)
 	 * only empty directories), remove them.
 	 */
 	struct strbuf path;
-	int result;
+	int result, save_errno;
 
 	strbuf_init(&path, 20);
 	strbuf_addstr(&path, file);
 
 	result = remove_dir_recursively(&path, REMOVE_DIR_EMPTY_ONLY);
+	save_errno = errno;
 
 	strbuf_release(&path);
+	errno = save_errno;
 
 	return result;
 }
@@ -2056,6 +2058,7 @@ int dwim_log(const char *str, int len, unsigned char *sha1, char **log)
 	return logs_found;
 }
 
+/* This function should make sure errno is meaningful on error */
 static struct ref_lock *lock_ref_sha1_basic(const char *refname,
 					    const unsigned char *old_sha1,
 					    int flags, int *type_p)

-- 
2.0.1.546.gf603308
Previous: Ronnie SahlbergNext: Ronnie Sahlberg
Message 12 of 20 in “Use ref transactions”
  1. 00/19 Use ref transactionsRonnie Sahlberg, Jul 14, 2014
  2. 01/19 refs.c: remove ref_transaction_rollbackRonnie Sahlberg, Jul 14, 2014
  3. 02/19 refs.c: ref_transaction_commit should not free the transactionRonnie Sahlberg, Jul 14, 2014
  4. 03/19 refs.c: constify the sha arguments for ref_transaction_create|delete|updateRonnie Sahlberg, Jul 14, 2014
  5. 04/19 refs.c: allow passing NULL to ref_transaction_freeRonnie Sahlberg, Jul 14, 2014
  6. 05/19 refs.c: add a strbuf argument to ref_transaction_commit for error loggingRonnie Sahlberg, Jul 14, 2014
  7. 06/19 lockfile.c: add a new public function unable_to_lock_messageRonnie Sahlberg, Jul 14, 2014
  8. 07/19 lockfile.c: make lock_file return a meaningful errno on failureRonnie Sahlberg, Jul 14, 2014
  9. 08/19 refs.c: add an err argument to repack_without_refsRonnie Sahlberg, Jul 14, 2014
  10. 09/19 refs.c: make sure log_ref_setup returns a meaningful errnoRonnie Sahlberg, Jul 14, 2014
  11. 10/19 refs.c: verify_lock should set errno to something meaningfulRonnie Sahlberg, Jul 14, 2014
  12. 11/19 refs.c: make remove_empty_directories always set errno to something saneRonnie Sahlberg, Jul 14, 2014
  13. 12/19 refs.c: commit_packed_refs to return a meaningful errno on failureRonnie Sahlberg, Jul 14, 2014
  14. 13/19 refs.c: make resolve_ref_unsafe set errno to something meaningful on errorRonnie Sahlberg, Jul 14, 2014
  15. 14/19 refs.c: log_ref_write should try to return meaningful errnoRonnie Sahlberg, Jul 14, 2014
  16. 15/19 refs.c: make ref_update_reject_duplicates take a strbuf argument for errorsRonnie Sahlberg, Jul 14, 2014
  17. 16/19 refs.c: make update_ref_write update a strbuf on failureRonnie Sahlberg, Jul 14, 2014
  18. 17/19 update-ref: use err argument to get error from ref_transaction_commitRonnie Sahlberg, Jul 14, 2014
  19. 18/19 refs.c: remove the onerr argument to ref_transaction_commitRonnie Sahlberg, Jul 14, 2014
  20. 19/19 refs.c: change ref_transaction_update() to do error checking and return statusRonnie Sahlberg, Jul 14, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.