git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] Use BASIC_FLAGS for profile feedback

From
AKAndi Kleen <andi@firstfloor.org>
Date
Jul 4, 2014, 23:43 UTC
Message-ID
<1404517432-25185-2-git-send-email-andi@firstfloor.org>
In-Reply-To
<1404517432-25185-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>

Use BASIC_CFLAGS instead of CFLAGS to set up the profile feedback option in the Makefile.

This allows still overriding CFLAGS on the make command line without disabling profile feedback.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 07ea105..a9770ac 100644
--- a/Makefile
+++ b/Makefile
@@ -1552,13 +1552,13 @@ endif
 PROFILE_DIR := $(CURDIR)
 
 ifeq ("$(PROFILE)","GEN")
-	CFLAGS += -fprofile-generate=$(PROFILE_DIR) -DNO_NORETURN=1
+	BASIC_CFLAGS += -fprofile-generate=$(PROFILE_DIR) -DNO_NORETURN=1
 	EXTLIBS += -lgcov
 	export CCACHE_DISABLE = t
 	V = 1
 else
 ifneq ("$(PROFILE)","")
-	CFLAGS += -fprofile-use=$(PROFILE_DIR) -fprofile-correction -DNO_NORETURN=1
+	BASIC_CFLAGS += -fprofile-use=$(PROFILE_DIR) -fprofile-correction -DNO_NORETURN=1
 	export CCACHE_DISABLE = t
 	V = 1
 endif
-- 
2.0.1
Previous: Andi KleenNext: Andi Kleen
Message 2 of 11 in “Fix the bitrotted profile feedback build”
  1. Andi KleenJul 4, 2014
  2. 1/5 Use BASIC_FLAGS for profile feedbackAndi Kleen, Jul 4, 2014
  3. 2/5 Don't define away __attribute__ on gccAndi Kleen, Jul 4, 2014
  4. 3/5 Run the perf test suite for profile feedback tooAndi Kleen, Jul 4, 2014
  5. Junio C HamanoJul 7, 2014
  6. Andi KleenJul 7, 2014
  7. 4/5 Fix profile feedback with -jN and add profile-fastAndi Kleen, Jul 4, 2014
  8. 5/5 Add a little script to compare two make perf runsAndi Kleen, Jul 4, 2014
  9. Bert WesargJul 6, 2014
  10. Andi KleenJul 6, 2014
  11. Bert WesargJul 6, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.