[PATCH 1/2] t6023-merge-file.sh: fix and mark as broken invalid tests
- From
Max Kirillov <max@max630.net>
- Date
- Jun 28, 2014, 19:37 UTC
- Message-ID
- <1403984243-22717-2-git-send-email-max@max630.net>
- In-Reply-To
- <1403984243-22717-1-git-send-email-max@max630.net>
Tests "merge without conflict (missing LF at EOF" and "merge result added missing LF" are meaningless - the first one is identical to "merge without conflict" and the second compares results of those identical tests, which are always same.
This has been so since their addition in ba1f5f3537. Probably "new4.txt" was meant to be used instead of "new2.txt". Unfortunately, the current merge-file breaks with new4 - conflict is reported. They also fail at that revision if fixed.
Fix the file reference to "new4.txt" and mark the tests as failing - they look like legitimate expectations, just not satisfied at time being.
Signed-off-by: Max Kirillov <max@max630.net> --- t/t6023-merge-file.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t6023-merge-file.sh b/t/t6023-merge-file.sh index d9f3439..6da921c 100755 --- a/t/t6023-merge-file.sh +++ b/t/t6023-merge-file.sh @@ -77,10 +77,10 @@ test_expect_success "merge without conflict (--quiet)" \ "git merge-file --quiet test.txt orig.txt new2.txt" cp new1.txt test2.txt -test_expect_success "merge without conflict (missing LF at EOF)" \ - "git merge-file test2.txt orig.txt new2.txt" +test_expect_failure "merge without conflict (missing LF at EOF)" \ + "git merge-file test2.txt orig.txt new4.txt" -test_expect_success "merge result added missing LF" \ +test_expect_failure "merge result added missing LF" \ "test_cmp test.txt test2.txt" cp test.txt backup.txt
-- 2.0.0.526.g5318336