git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v10 1/1] refs.c: SSE2 optimizations for check_refname_component

From
David Turner <dturner@twopensource.com>
Date
Jun 17, 2014, 18:07 UTC
Message-ID
<1403028433.5629.94.camel@stross>
In-Reply-To
<xmqq8uovmn0d.fsf@gitster.dls.corp.google.com>
On Tue, 2014-06-17 at 11:03 -0700, Junio C Hamano wrote:
Show 31 quoted lines
> David Turner <dturner@twopensource.com> writes:
> 
> > Optimize check_refname_component using SSE2 on x86_64.
> >
> > git rev-parse HEAD is a good test-case for this, since it does almost
> > nothing except parse refs.  For one particular repo with about 60k
> > refs, almost all packed, the timings are:
> >
> > Look up table: 29 ms
> > SSE2:          23 ms
> >
> > This cuts about 20% off of the runtime.
> >
> > Ondřej Bílka <neleai@seznam.cz> suggested an SSE2 approach to the
> > substring searches, which netted a speed boost over the SSE4.2 code I
> > had initially written.
> >
> > Signed-off-by: David Turner <dturner@twitter.com>
> > ---
> 
> When applied on top of your dde8a902 (refs.c: optimize
> check_refname_component(), 2014-06-03), this seems to fail t1402 for
> me.
> 
> Test Summary Report
> -------------------
> t1402-check-ref-format.sh (Wstat: 256 Tests: 93 Failed: 9)
>   Failed tests:  28, 36, 38, 40, 63, 75, 77, 85-86
>   Non-zero exit status: 1
> 
> #28 is the one that runs "check-ref-format heads/v@{ation".

Oops, I didn't even notice that test! I was looking only at t5511! Will fix.

Previous: Junio C Hamano
Message 4 of 4 in “(unknown)”
  1. David TurnerJun 17, 2014
  2. 1/1 refs.c: SSE2 optimizations for check_refname_componentDavid Turner, Jun 17, 2014
  3. Junio C HamanoJun 17, 2014
  4. David TurnerJun 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.