git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 09/14] refs.c: only write reflog update if msg is non-NULL

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Jun 16, 2014, 16:51 UTC
Message-ID
<1402937505-6091-10-git-send-email-sahlberg@google.com>
In-Reply-To
<1402937505-6091-1-git-send-email-sahlberg@google.com>

When performing a reflog transaction update, only write to the reflog iff msg is non-NULL. This can then be combined with REFLOG_TRUNCATE to perform an update that only truncates but does not write.

Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
 refs.c | 5 +++--
 refs.h | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/refs.c b/refs.c
index 379b50e..2163c90 100644
--- a/refs.c
+++ b/refs.c
@@ -3785,8 +3785,9 @@ int transaction_commit(struct ref_transaction *transaction,
 				update->reflog_fd = -1;
 				continue;
 			}
-		if (log_ref_write_fd(update->reflog_fd, update->old_sha1,
-				     update->new_sha1,
+		if (update->msg &&
+		    log_ref_write_fd(update->reflog_fd,
+				     update->old_sha1, update->new_sha1,
 				     update->committer, update->msg)) {
 			error("Could write to reflog: %s. %s",
 			      update->refname, strerror(errno));
diff --git a/refs.h b/refs.h
index 7c3a9ca..b0e339b 100644
--- a/refs.h
+++ b/refs.h
@@ -336,6 +336,7 @@ int transaction_delete_sha1(struct ref_transaction *transaction,
 /*
  * Append a reflog entry for refname. If the REFLOG_TRUNCATE flag is set
  * this update will first truncate the reflog before writing the entry.
+ * If msg is NULL no update will be written to the log.
  */
 int transaction_update_reflog(struct ref_transaction *transaction,
 			      const char *refname,

-- 
2.0.0.770.gd892650.dirty
Previous: Ronnie SahlbergNext: Ronnie Sahlberg
Message 10 of 15 in “ref-transactions-reflog”
  1. 00/14 ref-transactions-reflogRonnie Sahlberg, Jun 16, 2014
  2. 01/14 refs.c make ref_transaction_create a wrapper to ref_transaction_updateRonnie Sahlberg, Jun 16, 2014
  3. 02/14 refs.c: make ref_transaction_delete a wrapper for ref_transaction_updateRonnie Sahlberg, Jun 16, 2014
  4. 03/14 refs.c: rename the transaction functionsRonnie Sahlberg, Jun 16, 2014
  5. 04/14 refs.c: add a new update_type field to ref_updateRonnie Sahlberg, Jun 16, 2014
  6. 05/14 refs.c: add a function to append a reflog entry to a fdRonnie Sahlberg, Jun 16, 2014
  7. 06/14 lockfile.c: make hold_lock_file_for_append preserve meaningful errnoRonnie Sahlberg, Jun 16, 2014
  8. 07/14 refs.c: add a transaction function to append a reflog entryRonnie Sahlberg, Jun 16, 2014
  9. 08/14 refs.c: add a flag to allow reflog updates to truncate the logRonnie Sahlberg, Jun 16, 2014
  10. 09/14 refs.c: only write reflog update if msg is non-NULLRonnie Sahlberg, Jun 16, 2014
  11. 10/14 refs.c: allow multiple reflog updates during a single transactionRonnie Sahlberg, Jun 16, 2014
  12. 11/14 reflog.c: use a reflog transaction when writing during expireRonnie Sahlberg, Jun 16, 2014
  13. 12/14 refs.c: rename log_ref_setup to create_reflogRonnie Sahlberg, Jun 16, 2014
  14. 13/14 refs.c: make unlock_ref/close_ref/commit_ref staticRonnie Sahlberg, Jun 16, 2014
  15. 14/14 refs.c: remove lock_any_ref_for_updateRonnie Sahlberg, Jun 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.