git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] refs.c: make the *_packed_refs functions static

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Jun 5, 2014, 23:26 UTC
Message-ID
<1402010788-8236-3-git-send-email-sahlberg@google.com>
In-Reply-To
<1402010788-8236-1-git-send-email-sahlberg@google.com>

We no longer need to expose the lock/add/commit/rollback functions for packed refs anymore so make them static and remove them from the api.

Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
 refs.c |  8 ++++----
 refs.h | 28 ----------------------------
 2 files changed, 4 insertions(+), 32 deletions(-)
diff --git a/refs.c b/refs.c
index 6aa64dd..530947e 100644
--- a/refs.c
+++ b/refs.c
@@ -1123,7 +1123,7 @@ static struct ref_dir *get_packed_refs(struct ref_cache *refs)
 	return get_packed_ref_dir(get_packed_ref_cache(refs));
 }
 
-void add_packed_ref(const char *refname, const unsigned char *sha1)
+static void add_packed_ref(const char *refname, const unsigned char *sha1)
 {
 	struct packed_ref_cache *packed_ref_cache =
 		get_packed_ref_cache(&ref_cache);
@@ -2211,7 +2211,7 @@ static int write_packed_entry_fn(struct ref_entry *entry, void *cb_data)
 	return 0;
 }
 
-int lock_packed_refs(int flags)
+static int lock_packed_refs(int flags)
 {
 	struct packed_ref_cache *packed_ref_cache;
 
@@ -2234,7 +2234,7 @@ int lock_packed_refs(int flags)
  * Commit the packed refs changes.
  * On error we must make sure that errno contains a meaningful value.
  */
-int commit_packed_refs(void)
+static int commit_packed_refs(void)
 {
 	struct packed_ref_cache *packed_ref_cache =
 		get_packed_ref_cache(&ref_cache);
@@ -2259,7 +2259,7 @@ int commit_packed_refs(void)
 	return error;
 }
 
-void rollback_packed_refs(void)
+static void rollback_packed_refs(void)
 {
 	struct packed_ref_cache *packed_ref_cache =
 		get_packed_ref_cache(&ref_cache);
diff --git a/refs.h b/refs.h
index 3c99619..e92cb92 100644
--- a/refs.h
+++ b/refs.h
@@ -118,34 +118,6 @@ extern int for_each_rawref(each_ref_fn, void *);
 extern void warn_dangling_symref(FILE *fp, const char *msg_fmt, const char *refname);
 
 /*
- * Lock the packed-refs file for writing.  Flags is passed to
- * hold_lock_file_for_update().  Return 0 on success.
- */
-extern int lock_packed_refs(int flags);
-
-/*
- * Add a reference to the in-memory packed reference cache.  This may
- * only be called while the packed-refs file is locked (see
- * lock_packed_refs()).  To actually write the packed-refs file, call
- * commit_packed_refs().
- */
-extern void add_packed_ref(const char *refname, const unsigned char *sha1);
-
-/*
- * Write the current version of the packed refs cache from memory to
- * disk.  The packed-refs file must already be locked for writing (see
- * lock_packed_refs()).  Return zero on success.
- */
-extern int commit_packed_refs(void);
-
-/*
- * Rollback the lockfile for the packed-refs file, and discard the
- * in-memory packed reference cache.  (The packed-refs file will be
- * read anew if it is needed again after this function is called.)
- */
-extern void rollback_packed_refs(void);
-
-/*
  * Flags for controlling behaviour of pack_refs()
  * PACK_REFS_PRUNE: Prune loose refs after packing
  * PACK_REFS_ALL:   Pack _all_ refs, not just tags and already packed refs
-- 
2.0.0.583.g402232d
Previous: Ronnie Sahlberg
Message 5 of 5 in “Write multi-ref updates directly to packed refs”
  1. 0/2 Write multi-ref updates directly to packed refsRonnie Sahlberg, Jun 5, 2014
  2. 1/2 refs.c: write updates to packed refs when a transaction has more than one refRonnie Sahlberg, Jun 5, 2014
  3. Eric SunshineJun 8, 2014
  4. Ronnie SahlbergJun 9, 2014
  5. 2/2 refs.c: make the *_packed_refs functions staticRonnie Sahlberg, Jun 5, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.