git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v12 41/41] refs.c: make write_ref_sha1 static

From
Ronnie Sahlberg <sahlberg@google.com>
Date
May 29, 2014, 16:07 UTC
Message-ID
<1401379676-9307-15-git-send-email-sahlberg@google.com>
In-Reply-To
<1401379676-9307-1-git-send-email-sahlberg@google.com>
No external users call write_ref_sha1 any more so lets declare it static.
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
 refs.c | 6 +++++-
 refs.h | 3 ---
 2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/refs.c b/refs.c
index 6414afc..aefa5bc 100644
--- a/refs.c
+++ b/refs.c
@@ -2618,6 +2618,9 @@ static int rename_tmp_log(const char *newrefname)
 	return 0;
 }
 
+static int write_ref_sha1(struct ref_lock *lock, const unsigned char *sha1,
+			  const char *logmsg);
+
 int rename_ref(const char *oldrefname, const char *newrefname, const char *logmsg)
 {
 	unsigned char sha1[20], orig_sha1[20];
@@ -2848,7 +2851,8 @@ static int is_branch(const char *refname)
 	return !strcmp(refname, "HEAD") || starts_with(refname, "refs/heads/");
 }
 
-int write_ref_sha1(struct ref_lock *lock,
+/** Writes sha1 into the ref specified by the lock. **/
+static int write_ref_sha1(struct ref_lock *lock,
 	const unsigned char *sha1, const char *logmsg)
 {
 	static char term = '\n';
diff --git a/refs.h b/refs.h
index 88732a1..88020c5 100644
--- a/refs.h
+++ b/refs.h
@@ -195,9 +195,6 @@ extern int commit_ref(struct ref_lock *lock);
 /** Release any lock taken but not written. **/
 extern void unlock_ref(struct ref_lock *lock);
 
-/** Writes sha1 into the ref specified by the lock. **/
-extern int write_ref_sha1(struct ref_lock *lock, const unsigned char *sha1, const char *msg);
-
 /** Setup reflog before using. **/
 int log_ref_setup(const char *refname, char *logfile, int bufsize);
 
-- 
2.0.0.rc3.474.g3833130
Previous: Ronnie SahlbergNext: Ronnie Sahlberg
Message 17 of 18 in “Use ref transactions for all ref updates”
  1. 00/44 Use ref transactions for all ref updatesRonnie Sahlberg, May 29, 2014
  2. 06/41 refs.c: add an err argument to repack_without_refsRonnie Sahlberg, May 29, 2014
  3. Jonathan NiederMay 29, 2014
  4. Ronnie SahlbergJun 3, 2014
  5. 08/41 refs.c: add an err argument to delete_ref_looseRonnie Sahlberg, May 29, 2014
  6. 16/41 refs.c: add transaction.status and track OPEN/CLOSED/ERRORRonnie Sahlberg, May 29, 2014
  7. 24/41 receive-pack.c: use a reference transaction for updating the refsRonnie Sahlberg, May 29, 2014
  8. 25/41 fast-import.c: use a ref transaction when dumping tagsRonnie Sahlberg, May 29, 2014
  9. 26/41 walker.c: use ref transaction for ref updatesRonnie Sahlberg, May 29, 2014
  10. 31/41 refs.c: make prune_ref use a transaction to delete the refRonnie Sahlberg, May 29, 2014
  11. 32/41 refs.c: make delete_ref use a transactionRonnie Sahlberg, May 29, 2014
  12. 33/41 refs.c: pass the ref log message to _create/delete/update instead of _commitRonnie Sahlberg, May 29, 2014
  13. 36/41 refs.c: move the check for valid refname to lock_ref_sha1_basicRonnie Sahlberg, May 29, 2014
  14. 38/41 refs.c: pass a skip list to name_conflict_fnRonnie Sahlberg, May 29, 2014
  15. 39/41 refs.c: propagate any errno==ENOTDIR from _commit back to the callersRonnie Sahlberg, May 29, 2014
  16. 40/41 fetch.c: change s_update_ref to use a ref transactionRonnie Sahlberg, May 29, 2014
  17. 41/41 refs.c: make write_ref_sha1 staticRonnie Sahlberg, May 29, 2014
  18. Ronnie SahlbergMay 29, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.