Re: RFC: optionally reject case-clone branch names

From: David Turner <dturner@twopensource.com>
Date: May 28, 2014, 17:56 UTC
Message-ID: <1401299791.18134.74.camel@stross>
In-Reply-To: <xmqq7g55esg5.fsf@gitster.dls.corp.google.com>

On Wed, 2014-05-28 at 10:14 -0700, Junio C Hamano wrote:

Show 17 quoted lines

> David Turner <dturner@twopensource.com> writes:
> 
> > RFC follows:
> >
> > 1. On a case-insensitive server, git receive-pack ought to always reject
> > branches which are same-but-for-case of existing branches.
> > 2. On a case-sensitive server, the same rule by default, with an option
> > to allow the old behavior.
> >
> > Let me know if, should I write these patches, they would be likely to be
> > accepted.
> 
> There is another a lot simpler possiblity, no?
> 
> 3. On any server whose administrator chooses to enforce "one case
>    variant only" rule, install a pre-receive hook that enforces the
>    rule.

The reason I discovered this issue is that a user came to me to complain that suddenly their pulls were failing. Then I had to track down what the actual problem was (a colleague actually pointed it out to me).

We could add some hooks, but we have a lot of repos, some of which already have unique hooks that we would have to edit. And this approach wouldn't help the next person who gets into this situation, who would have to again figure out what went wrong, and add the appropriate hook.

Basically, I'm trying to take a poka-yoke approach. Does this seem reasonable?