git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/5] daemon.c child_handler(): replace signal() with sigaction()

From
Jeremiah Mahler <jmmahler@gmail.com>
Date
May 28, 2014, 06:14 UTC
Message-ID
<1401257655-6043-4-git-send-email-jmmahler@gmail.com>
In-Reply-To
<1401257655-6043-1-git-send-email-jmmahler@gmail.com>
From signal(2)
  The behavior of signal() varies across UNIX versions, and has also var‐
  ied historically across different versions of Linux.   Avoid  its  use:
  use sigaction(2) instead.  See Portability below.
Replaced signal() with sigaction() in daemon.c child_handler()
Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
---
 daemon.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/daemon.c b/daemon.c
index 78c4a1c..3c48dc0 100644
--- a/daemon.c
+++ b/daemon.c
@@ -791,12 +791,15 @@ static void handle(int incoming, struct sockaddr *addr, socklen_t addrlen)
 
 static void child_handler(int signo)
 {
+	struct sigaction sa;
 	/*
 	 * Otherwise empty handler because systemcalls will get interrupted
 	 * upon signal receipt
 	 * SysV needs the handler to be rearmed
 	 */
-	signal(SIGCHLD, child_handler);
+	memset(&sa, 0, sizeof(sa));
+	sa.sa_handler = child_handler;
+	sigaction(SIGCHLD, &sa, 0);
 }
 
 static int set_reuse_addr(int sockfd)
-- 
2.0.0.rc4.6.g127602c
Previous: Jeremiah MahlerNext: Jeremiah Mahler
Message 10 of 16 in “replace signal() with sigaction()”
  1. 0/5 replace signal() with sigaction()Jeremiah Mahler, May 28, 2014
  2. 1/5 progress.c: replace signal() with sigaction()Jeremiah Mahler, May 28, 2014
  3. Chris PackhamMay 28, 2014
  4. David KastrupMay 28, 2014
  5. Erik Faye-LundMay 28, 2014
  6. David KastrupMay 28, 2014
  7. Junio C HamanoMay 28, 2014
  8. Jeremiah MahlerMay 28, 2014
  9. 2/5 daemon.c run_service(): replace signal() with sigaction()Jeremiah Mahler, May 28, 2014
  10. 3/5 daemon.c child_handler(): replace signal() with sigaction()Jeremiah Mahler, May 28, 2014
  11. 4/5 daemon.c service_loop(): replace signal() with sigaction()Jeremiah Mahler, May 28, 2014
  12. 5/5 connect.c: replace signal() with sigaction()Jeremiah Mahler, May 28, 2014
  13. Johannes SixtMay 28, 2014
  14. Chris PackhamMay 28, 2014
  15. Erik Faye-LundMay 28, 2014
  16. Jeremiah MahlerMay 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.