git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 02/19] contrib/examples/git-clone.sh: convert test -a/-o to && and ||

From
Elia Pinto <gitter.spiros@gmail.com>
Date
May 20, 2014, 13:50 UTC
Message-ID
<1400593832-6510-3-git-send-email-gitter.spiros@gmail.com>
In-Reply-To
<1400593832-6510-1-git-send-email-gitter.spiros@gmail.com>

The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 contrib/examples/git-clone.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/examples/git-clone.sh b/contrib/examples/git-clone.sh
index b4c9376..08cf246 100755
--- a/contrib/examples/git-clone.sh
+++ b/contrib/examples/git-clone.sh
@@ -516,7 +516,7 @@ then
 
 	case "$no_checkout" in
 	'')
-		test "z$quiet" = z -a "z$no_progress" = z && v=-v || v=
+		test "z$quiet" = z && test "z$no_progress" = z && v=-v || v=
 		git read-tree -m -u $v HEAD HEAD
 	esac
 fi

-- 
1.7.10.4
Previous: Junio C HamanoNext: Elia Pinto
Message 5 of 27 in “convert test -a/-o to && and || patch series”
  1. 00/19 convert test -a/-o to && and || patch seriesElia Pinto, May 20, 2014
  2. 01/19 check_bindir: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  3. Junio C HamanoMay 20, 2014
  4. Junio C HamanoMay 20, 2014
  5. 02/19 contrib/examples/git-clone.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  6. 03/19 contrib/examples/git-commit.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  7. 04/19 contrib/examples/git-merge.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  8. 05/19 contrib/examples/git-repack.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  9. 06/19 contrib/examples/git-resolve.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  10. 07/19 git-bisect.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  11. 08/19 git-mergetool.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  12. 09/19 git-rebase--interactive.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  13. 10/19 git-submodule.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  14. Matthieu MoyMay 20, 2014
  15. Johannes SixtMay 20, 2014
  16. 11/19 t/t0025-crlf-auto.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  17. 12/19 t/t0026-eol-config.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  18. 13/19 t/t4102-apply-rename.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  19. 14/19 t/t5000-tar-tree.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  20. 15/19 t/t5403-post-checkout-hook.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  21. 16/19 t/t5537-fetch-shallow.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  22. 17/19 t/t5538-push-shallow.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  23. 18/19 t/t9814-git-p4-rename.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  24. 19/19 t/test-lib-functions.sh: convert test -a/-o to && and ||Elia Pinto, May 20, 2014
  25. Matthieu MoyMay 20, 2014
  26. Junio C HamanoMay 20, 2014
  27. Jonathan NiederMay 20, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.