Re: bug report: gitk crashes on git commit with emoji (utf-8)

From: Tomek Mrugalski <tomasz.mrugalski@gmail.com>
Date: Oct 13, 2020, 08:00 UTC
Message-ID: <13bc5c41-8989-5551-51ba-eec30b59900c@gmail.com>
In-Reply-To: <3318fdd6-5709-1d3c-64d8-01d029803635@arcor.de>

On 11.10.2020 13:47, Peter Oberndorfer wrote:

Show 10 quoted lines

>> $ ~/devel-ssd/git/gitk-git/gitk X Error of failed request:
>> BadLength (poly request too large or internal Xlib length error) 
>> Major opcode of failed request:  139 (RENDER) Minor opcode of
>> failed request:  20 (RenderAddGlyphs) Serial number of failed
>> request:  3065 Current serial number in output stream:  3148
> 
>> Is there a workaround I could try?
>> 
> I managed to work around this problem by installing the Ubuntu
> package 'fonts-symbola'.

Hi Peter,

Yes, the workaround works on 2.28 on ubuntu 20.04.

Show 5 quoted lines

> Testing with your repository, the Emoji is still not displayed
> correctly but gitk does not crash anymore.
> 
> This issue (and the workaround) seems to be tracked at 
> https://bugs.launchpad.net/ubuntu/+source/git/+bug/1852985

Uh, missed that. Thanks for the pointer.

Hmm. It seems this is very dependent on what kind of fonts are in the system and the lib could crash. You may possibly consider implementing some sort of --dont-display-utf8 option. Or perhaps waiting for the xlib bug to be fixed is less involving option.

Anyway, I can again use gitk.

Thanks again for this great software.

Tomek