git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/6] completion: bash: cleanup cygwin check

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 30, 2014, 11:07 UTC
Message-ID
<1398856065-2982-7-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1398856065-2982-1-git-send-email-felipe.contreras@gmail.com>
Avoid Yoda conditions, use test, and cleaner statement.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index f1ce962..34edef9 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2600,6 +2600,5 @@ __git_complete gitk __gitk_main
 # when the user has tab-completed the executable name and consequently
 # included the '.exe' suffix.
 #
-if [ Cygwin = "$(uname -o 2>/dev/null)" ]; then
+test "$(uname -o 2>/dev/null)" = "Cygwin" &&
 __git_complete git.exe __git_main
-fi

-- 
1.9.2+fc1.11.g71fb719
Previous: Felipe Contreras
Message 7 of 7 in “completion: fixes”
  1. 0/6 completion: fixesFelipe Contreras, Apr 30, 2014
  2. 1/6 completion: bash: remove old wrappersFelipe Contreras, Apr 30, 2014
  3. 2/6 completion: bash: remove zsh wrapperFelipe Contreras, Apr 30, 2014
  4. 3/6 completion: zsh: don't hide ourselvesFelipe Contreras, Apr 30, 2014
  5. 4/6 completion: remove zsh hackFelipe Contreras, Apr 30, 2014
  6. 5/6 completion: zsh: trivial cleanupsFelipe Contreras, Apr 30, 2014
  7. 6/6 completion: bash: cleanup cygwin checkFelipe Contreras, Apr 30, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.