git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 4/5] patch-id: change default to stable

From
MTMichael S. Tsirkin <mst@redhat.com>
Date
Apr 27, 2014, 18:15 UTC
Message-ID
<1398622524-26207-4-git-send-email-mst@redhat.com>
In-Reply-To
<1398622524-26207-1-git-send-email-mst@redhat.com>

--stable has been the default in 'next' for a few weeks with no ill effects. Change the default to that so that users don't have to remember to enable it.

Update documentation to match behaviour change.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 builtin/patch-id.c             | 4 ++--
 Documentation/git-patch-id.txt | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin/patch-id.c b/builtin/patch-id.c
index 77db873..e11a6a7 100644
--- a/builtin/patch-id.c
+++ b/builtin/patch-id.c
@@ -185,9 +185,9 @@ int cmd_patch_id(int argc, const char **argv, const char *prefix)
 
 	git_config(git_patch_id_config, &stable);
 
-	/* If nothing is set, default to unstable. */
+	/* If nothing is set, default to stable. */
 	if (stable < 0)
-		stable = 0;
+		stable = 1;
 
 	if (argc == 2 && !strcmp(argv[1], "--stable"))
 		stable = 1;
diff --git a/Documentation/git-patch-id.txt b/Documentation/git-patch-id.txt
index fa562d3..1e2ca75 100644
--- a/Documentation/git-patch-id.txt
+++ b/Documentation/git-patch-id.txt
@@ -43,7 +43,7 @@ OPTIONS
 	   of "-O<orderfile>", thereby making existing databases storing such
 	   "unstable" or historical patch-ids unusable.
 
-	This is the default if patchid.stable is set to true.
+	This is the default.
 
 --unstable::
 	Use an "unstable" hash as the patch ID. With this option,
@@ -52,7 +52,7 @@ OPTIONS
 	patch-ids produced by git 1.9 and older (who do not deal with reordered
 	patches) may want to use this option.
 
-	This is the default.
+	This is the default if patchid.stable is set to false.
 
 <patch>::
 	The diff to create the ID of.
-- 
MST
Previous: Michael S. TsirkinNext: Michael S. Tsirkin
Message 6 of 8 in “patch-id: make it stable against hunk reordering”
  1. 1/5 patch-id: make it stable against hunk reorderingMichael S. Tsirkin, Apr 27, 2014
  2. 2/5 test: add test_write_lines helperMichael S. Tsirkin, Apr 27, 2014
  3. test doc: test_write_lines does not split its argumentsJonathan Nieder, May 5, 2014
  4. Michael S. TsirkinMay 6, 2014
  5. 3/5 patch-id-test: test stable and unstable behaviourMichael S. Tsirkin, Apr 27, 2014
  6. 4/5 patch-id: change default to stableMichael S. Tsirkin, Apr 27, 2014
  7. 5/5 t4204-patch-id.sh: default is now stableMichael S. Tsirkin, Apr 27, 2014
  8. Junio C HamanoApr 29, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.