[PATCH v3 11/25] prepare_index(): declare return value to be (const char *)
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Apr 14, 2014, 13:54 UTC
- Message-ID
- <1397483695-10888-12-git-send-email-mhagger@alum.mit.edu>
- In-Reply-To
- <1397483695-10888-1-git-send-email-mhagger@alum.mit.edu>
Declare the return value to be const to make it clear that we aren't giving callers permission to write over the string that it points at. (The return value is the filename field of a struct lock_file, which can be used by a signal handler at any time and therefore shouldn't be tampered with.)
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- builtin/commit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/commit.c b/builtin/commit.c index 9cfef6c..8ffb3ef 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -302,8 +302,8 @@ static void refresh_cache_or_die(int refresh_flags) die_resolve_conflict("commit"); } -static char *prepare_index(int argc, const char **argv, const char *prefix, - const struct commit *current_head, int is_status) +static const char *prepare_index(int argc, const char **argv, const char *prefix, + const struct commit *current_head, int is_status) { int fd; struct string_list partial;
-- 1.9.1