git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] Make update-refs more atomic

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Apr 8, 2014, 23:21 UTC
Message-ID
<1396999284-4691-1-git-send-email-sahlberg@google.com>

refs.c:update_refs() intermingles doing updates and checks with actually applying changes to the refs in loops that abort on error. This is done one ref at a time and means that if an error is detected that will fail the operation after only some of the ref operations have been been updated on the disk.

These patches change the update and delete functions to use a three call pattern of

1, lock 2, update, or flag for deletion 3, apply on disk

In the final patch I change update_refs to perform these actions in three separate loops where the final loop to 'apply on disk' all the changes will only be performed if there were no error conditions detected during any of previous loops.

This should make the changes of refs in update_refs slightly more atomic.

This may overlap with other current patch series for making refs updates more atomic which may mean these patches become obsolete, but I would still like some review and feedback on these changes.

Ronnie Sahlberg (3):
  Split writing and commiting a ref into two separate functions.
  Split delete_ref_loose() into a separate flag-for-deletion and commit
    phase
  Change update_refs to run a single commit loop once all work is
    finished.
 branch.c               | 10 ++++--
 builtin/commit.c       |  5 +++
 builtin/fetch.c        |  7 +++-
 builtin/receive-pack.c |  4 +++
 builtin/replace.c      |  6 +++-
 builtin/tag.c          |  6 +++-
 fast-import.c          |  7 +++-
 refs.c                 | 90 +++++++++++++++++++++++++++++++++-----------------
 refs.h                 |  6 ++++
 sequencer.c            |  4 +++
 walker.c               |  4 +++
 11 files changed, 112 insertions(+), 37 deletions(-)
-- 
1.9.1.477.g7668a0d.dirty
Next: Ronnie Sahlberg
Message 1 of 5 in “Make update-refs more atomic”
  1. 0/3 Make update-refs more atomicRonnie Sahlberg, Apr 8, 2014
  2. 1/3 Split writing and commiting a ref into two separate functions.Ronnie Sahlberg, Apr 8, 2014
  3. 2/3 Split delete_ref_loose() into a separate flag-for-deletion and commit phaseRonnie Sahlberg, Apr 8, 2014
  4. 3/3 Change update_refs to run a single commit loop once all work is finished.Ronnie Sahlberg, Apr 8, 2014
  5. Junio C HamanoApr 9, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.