git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] Remove inline from git_fnmatch in dir.c

From
Charles Bailey <cbailey32@bloomberg.net>
Date
Mar 29, 2014, 15:39 UTC
Message-ID
<1396107541-22974-2-git-send-email-cbailey32@bloomberg.net>
In-Reply-To
<1396107541-22974-1-git-send-email-cbailey32@bloomberg.net>

Now that it calls a static inline function, it cannot be an inline definition with external linkage. Remove inline and make it an external definition.

Signed-off-by: Charles Bailey <cbailey32@bloomberg.net>
---
 dir.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dir.c b/dir.c
index 99f5303..eb6f581 100644
--- a/dir.c
+++ b/dir.c
@@ -54,9 +54,9 @@ int fnmatch_icase(const char *pattern, const char *string, int flags)
 			 NULL);
 }
 
-inline int git_fnmatch(const struct pathspec_item *item,
-		       const char *pattern, const char *string,
-		       int prefix)
+int git_fnmatch(const struct pathspec_item *item,
+		const char *pattern, const char *string,
+		int prefix)
 {
 	if (prefix > 0) {
 		if (ps_strncmp(item, pattern, string, prefix))
-- 
1.8.5.1.2.ge5d1dab
Previous: Charles BaileyNext: Charles Bailey
Message 2 of 6 in “AIX fixes”
  1. Charles BaileyMar 29, 2014
  2. 1/2 Remove inline from git_fnmatch in dir.cCharles Bailey, Mar 29, 2014
  3. 2/2 Don't rely on strerror text when testing rmdir failureCharles Bailey, Mar 29, 2014
  4. Jens LehmannMar 29, 2014
  5. Charles BaileyMar 29, 2014
  6. Junio C HamanoMar 31, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.