[PATCH v2] diff-no-index.c : rewrite read_directory() to use is_dot_or_dotdot().

From

ADAndrei Dinu <mandrei.dinu@gmail.com>

Date

Mar 19, 2014, 13:29 UTC

Message-ID

<1395235753-3285-1-git-send-email-mandrei.dinu@gmail.com>

replace manual "."/".." check with is_dot_or_dotdot().

choose to implement my own function because did't find the defined one.

[1]: http://article.gmane.org/gmane.comp.version-control.git/244420

Signed-off-by: Andrei Dinu <mandrei.dinu@gmail.com>

---
 I plan on applying to GSoc 2014

 diff-no-index.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/diff-no-index.c b/diff-no-index.c
index 83cdbf7..d91ea3b 100644
--- a/diff-no-index.c
+++ b/diff-no-index.c
@@ -19,10 +19,10 @@
 static int is_dot_or_dotdot(const char *path)
 {
     if (path[0] == '.' && path[1] == '\0')
-        return 0;
+        return 1;
     else if (path[0] == '.' && path[1] == '.' && path[2] == '\0')
-        return 0;
-    return 1;
+        return 1;
+    return 0;
 }
 
 static int read_directory(const char *path, struct string_list *list)
@@ -34,7 +34,7 @@ static int read_directory(const char *path, struct string_list *list)
 		return error("Could not open directory %s", path);
 
 	while ((e = readdir(dir)))
-		if (is_dot_or_dotdot(e->d_name))
+		if (!is_dot_or_dotdot(e->d_name))
 			string_list_insert(list, e->d_name);
 
 	closedir(dir);

-- 
1.7.9.5