git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/2] [GSoC] diff:use is_dot_or_dotdot() in code

From
Brian Bourn <ba.bourn@gmail.com>
Date
Mar 19, 2014, 06:29 UTC
Message-ID
<1395210578-1532-2-git-send-email-ba.bourn@gmail.com>
In-Reply-To
<1395210578-1532-1-git-send-email-ba.bourn@gmail.com>
From: Brian Bourn <ba.bourn@gmail.com>
Subject: replace manual "."/".." check with is_dot_or_dotdot()
Signed-off-by: Brian Bourn <ba.bourn@gmail.com>
---
Part 2 of my GSoC submission where the actual change is made
 diff-no-index.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/diff-no-index.c b/diff-no-index.c
index ec51106..c554691 100644
--- a/diff-no-index.c
+++ b/diff-no-index.c
@@ -15,6 +15,7 @@
 #include "log-tree.h"
 #include "builtin.h"
 #include "string-list.h"
+#include "dir.h"
 
 static int read_directory_contents(const char *path, struct string_list *list)
 {
@@ -25,7 +26,7 @@ static int read_directory_contents(const char *path, struct string_list *list)
 		return error("Could not open directory %s", path);
 
 	while ((e = readdir(dir)))
-		if (strcmp(".", e->d_name) && strcmp("..", e->d_name))
+		if (!is_dot_or_dotdot(e->d_name))
 			string_list_insert(list, e->d_name);
 
 	closedir(dir);
-- 
1.9.0
Previous: Brian BournNext: Eric Sunshine
Message 2 of 4 in “[GSoC] diff: rename read_directory()”
  1. 1/2 [GSoC] diff: rename read_directory()Brian Bourn, Mar 19, 2014
  2. 2/2 [GSoC] diff:use is_dot_or_dotdot() in codeBrian Bourn, Mar 19, 2014
  3. Eric SunshineMar 19, 2014
  4. Eric SunshineMar 19, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.